From: Mark H Weaver <mhw@netris.org>
To: Omar Radwan <toxemicsquire4@gmail.com>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] gnu: Add urwid
Date: Sun, 01 Feb 2015 21:32:17 -0500 [thread overview]
Message-ID: <87bnlddowe.fsf@netris.org> (raw)
In-Reply-To: <CAMwaQAKCdSvoGGABL7_jiwfbjVypNev-STG5Ma_mjH5bpnOzxg@mail.gmail.com> (Omar Radwan's message of "Sun, 1 Feb 2015 16:14:39 -0800")
Omar Radwan <toxemicsquire4@gmail.com> writes:
> From 7d65731aaec1b3dbca9364bc2b0f18c9fc9992e5 Mon Sep 17 00:00:00 2001
> From: Omar Radwan <toxemicsquire4@gmail.com>
> Date: Sun, 1 Feb 2015 14:43:59 -0800
> Subject: [PATCH] gnu: Add urwid
Minor nits: add a period above, and:
> * gnu/packages/python.scm(urwid) New variable.
This should be:
* gnu/packages/python.scm (urwid): New variable.
(add missing space and colon)
> ---
> gnu/packages/python.scm | 27 ++++++++++++++++++++++++++-
> 1 file changed, 26 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 4b30695..19016b4 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -5,7 +5,7 @@
> ;;; Copyright © 2014 Mark H Weaver <mhw@netris.org>
> ;;; Copyright © 2014 Eric Bavier <bavier@member.fsf.org>
> ;;; Copyright © 2014, 2015 Federico Beffa <beffa@fbengineering.ch>
> -;;;
> +;;; Copyright © 2015 Omar Radwan <toxemicsquire4@gmail.com>
> ;;; This file is part of GNU Guix.
Please keep the blank line below the copyright notices.
More importantly, the encoding of the "©" is getting munged somewhere,
so this patch won't apply cleanly.
> ;;;
> ;;; GNU Guix is free software; you can redistribute it and/or modify it
> @@ -2848,3 +2848,28 @@ and written in Python.")
>
> (define-public python2-html5lib
> (package-with-python2 python-html5lib))
> +
> +
> +(define-public urwid
> + (package
> + (name "urwid")
> + (version "1.3.0")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> +"https://pkgs.fedoraproject.org/repo/pkgs/python-urwid/urwid-1.3.0.tar.gz/a989acd54f4ff1a554add464803a9175/urwid-1.3.0.tar.gz")) ;;upstream can't be used because Pypi don't have ETag headers in qoutes
How about this instead:
(uri (list (string-append
"https://pypi.python.org/packages/source/u/urwid/urwid-"
version ".tar.gz")
;; Downloading from the upstream URI above fails due to an
;; invalid ETag header.
"https://pkgs.fedoraproject.org/repo/pkgs/python-urwid/urwid-1.3.0.tar.gz/a989acd54f4ff1a554add464803a9175/urwid-1.3.0.tar.gz"))
This first tries to download from the canonical upstream URL, in case
they fix their ETag headers, but falls back to the Fedora mirror.
> + (sha256
> + (base32
> + "18mb0yy94sjc434rd61m2sfnw27sa0nyrszpj5a9r9zh7fnlzw19"))))
> + (build-system python-build-system)
> + (inputs `(("python-2" ,python-2)
> +
> + ("python2-setuptools" ,python2-setuptools)))
When using 'python-build-system', instead of adding python-2 as an
input, we should do this instead:
(arguments `(#:python ,python-2))
And 'python2-setuptools' should be a native-input:
(native-inputs `(("python2-setuptools" ,python2-setuptools)))
> + (home-page "urwid.org/")
This should be a valid URL; in this case:
(home-page "http://urwid.org")
> + (synopsis "Console user interface library for Python")
> + (description
> + "Urwid is a console user interface library for python. It includes many features useful for text
> +console application")
Double-space between sentences, keep lines < 80 columns, and add an "s"
and period at the end, e.g.:
(description
"Urwid is a console user interface library for python. It includes many
features useful for text console applications.")
> + (license lgpl2.1)))
> +
Can you send an updated patch?
Thanks!
Mark
next prev parent reply other threads:[~2015-02-02 2:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-01 22:56 [PATCH] gnu: Add urwid Omar Radwan
2015-02-01 23:23 ` Omar Radwan
2015-02-02 0:14 ` Omar Radwan
2015-02-02 2:32 ` Mark H Weaver [this message]
2015-02-02 4:57 ` Omar Radwan
2015-02-02 5:42 ` Mark H Weaver
2015-02-02 17:46 ` Omar Radwan
2015-02-02 17:59 ` Andreas Enge
2015-02-03 3:37 ` Omar Radwan
2015-02-03 4:42 ` Mark H Weaver
2015-02-03 4:48 ` Omar Radwan
2015-02-03 5:37 ` Mark H Weaver
2015-02-03 17:20 ` Omar Radwan
2015-02-03 21:07 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bnlddowe.fsf@netris.org \
--to=mhw@netris.org \
--cc=guix-devel@gnu.org \
--cc=toxemicsquire4@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.