From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] build: ruby: Patch executables to set necessary gem load path. Date: Mon, 09 Mar 2015 23:19:36 +0100 Message-ID: <87bnk1q0ef.fsf@gnu.org> References: <871tl04aux.fsf@fsf.org> <87vbic2u7n.fsf@fsf.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55458) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YV61Y-0008HM-RH for guix-devel@gnu.org; Mon, 09 Mar 2015 18:19:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YV61U-0002i9-41 for guix-devel@gnu.org; Mon, 09 Mar 2015 18:19:44 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47836) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YV61U-0002i5-1S for guix-devel@gnu.org; Mon, 09 Mar 2015 18:19:40 -0400 In-Reply-To: <87vbic2u7n.fsf@fsf.org> (David Thompson's message of "Sat, 07 Mar 2015 19:45:00 -0500") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: David Thompson Cc: guix-devel@gnu.org David Thompson skribis: > David Thompson writes: > >> This patch addresses the issue of how to ensure that Ruby executables >> are able to load all of the additional Ruby libraries that they need in >> order to work: with a new 'patch-executables' build phase. Instead of >> using wrap-program, I instead take advantage of the wrappers that the >> 'gem' command already creates for Ruby executables. There's guaranteed >> to be a line in which the executable's host gem is loaded that looks >> like `gem 'foo', version`. I simply insert a Ruby code snippet above it >> that adds all of the necessary gems to the 'Gem.path' array. >> >> Users of Ruby programs must still apply the $GEM_PATH suggested by 'guix >> package --search-paths' in order for the gem that the executable belongs >> to (the gem that they explicitly installed) to be found. I think this >> is reasonable and much like how you must set the proper load paths for >> Guile programs to work. > > I can see that this won't be enough for any application whose Ruby gem > dependency tree is deeper than 1. I suppose I could use the transitive > inputs of the package, which would get everything, but that feels a bit > ugly. More thought needed... I guess it could recurse into the DAG, possibly with =E2=80=98bag-transitive-inputs=E2=80=99 or some such? Ludo=E2=80=99.