all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [PATCH] gnu: liba52: Fix source URI.
@ 2015-03-18 10:14 Taylan Ulrich Bayırlı/Kammer
  2015-03-19  8:54 ` Ludovic Courtès
  0 siblings, 1 reply; 2+ messages in thread
From: Taylan Ulrich Bayırlı/Kammer @ 2015-03-18 10:14 UTC (permalink / raw)
  To: guix-devel

[-- Attachment #1: Type: text/plain, Size: 270 bytes --]

Looks like the SourceForge mirror URI never worked for this package.
I'm not sure how I missed that (I think I coincidentally had a
non-mirror URI, noticed it after being done with the package, then
"fixed" it to use a mirror URI and didn't properly test if it works).


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch --]
[-- Type: text/x-diff, Size: 1283 bytes --]

From 87829d1b612035fcc54880b76eb6689ab99ebfb3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?=
 <taylanbayirli@gmail.com>
Date: Wed, 18 Mar 2015 10:52:37 +0100
Subject: [PATCH] gnu: liba52: Fix source URI.

* gnu/packages/video.scm (liba52): Fix the source URI; SourceForge mirror URIs
  don't work for this project presumably because it's misconfigured.
---
 gnu/packages/video.scm | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index b1c0c52..ce26812 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -77,8 +77,11 @@
     (version "0.7.4")
     (source (origin
               (method url-fetch)
-              (uri (string-append "mirror://sourceforge/liba52/a52dec-"
-                                  version ".tar.gz"))
+              (uri (string-append
+                    ;; A mirror://sourceforge URI doesn't work, presumably
+                    ;; because the SourceForge project is misconfigured.
+                    "http://liba52.sourceforge.net/files/a52dec-" version
+                    ".tar.gz"))
               (sha256
                (base32
                 "0czccp4fcpf2ykp16xcrzdfmnircz1ynhls334q374xknd5747d2"))))
-- 
2.2.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] gnu: liba52: Fix source URI.
  2015-03-18 10:14 [PATCH] gnu: liba52: Fix source URI Taylan Ulrich Bayırlı/Kammer
@ 2015-03-19  8:54 ` Ludovic Courtès
  0 siblings, 0 replies; 2+ messages in thread
From: Ludovic Courtès @ 2015-03-19  8:54 UTC (permalink / raw)
  To: Taylan Ulrich "Bayırlı/Kammer"; +Cc: guix-devel

taylanbayirli@gmail.com (Taylan Ulrich "Bayırlı/Kammer") skribis:

> Looks like the SourceForge mirror URI never worked for this package.

Good catch.

> I'm not sure how I missed that (I think I coincidentally had a
> non-mirror URI, noticed it after being done with the package, then
> "fixed" it to use a mirror URI and didn't properly test if it works).

Yes, once an origin is in store, it is not re-downloaded.  So it’s easy
to get the URI wrong.  ‘guix lint’ should help with that.

> From 87829d1b612035fcc54880b76eb6689ab99ebfb3 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?=
>  <taylanbayirli@gmail.com>
> Date: Wed, 18 Mar 2015 10:52:37 +0100
> Subject: [PATCH] gnu: liba52: Fix source URI.
>
> * gnu/packages/video.scm (liba52): Fix the source URI; SourceForge mirror URIs
>   don't work for this project presumably because it's misconfigured.

Sure please push (no need to repeat the rationale in the commit log.)

Thanks,
Ludo’.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-03-19  8:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-18 10:14 [PATCH] gnu: liba52: Fix source URI Taylan Ulrich Bayırlı/Kammer
2015-03-19  8:54 ` Ludovic Courtès

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.