all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] Add IBus.
Date: Thu, 26 Mar 2015 09:09:08 +0100	[thread overview]
Message-ID: <87bnjgqixn.fsf@mango.localdomain> (raw)
In-Reply-To: <87y4mwov05.fsf@gnu.org>


Ludovic Courtès writes:
>
>> +        (lambda* (#:key inputs outputs #:allow-other-keys)
>> +          ;; Make sure 'ibus-setup' runs with the correct PYTHONPATH and
>> +          ;; GI_TYPELIB_PATH.
>> +          (let ((out (assoc-ref outputs "out")))
>> +            (substitute* (string-append out "/bin/.ibus-setup-real")
>> +              (("exec ")
>> +               (string-append "export PYTHONPATH=\""
>> +                              (getenv "PYTHONPATH")
>> +                              "${PYTHONPATH:+:}$PYTHONPATH" "\"\n"
>> +                              "export GI_TYPELIB_PATH=\""
>> +                              (getenv "GI_TYPELIB_PATH")
>> +                              ":" out "/lib/girepository-1.0"
>> +                              "${GI_TYPELIB_PATH:+:}$GI_TYPELIB_PATH"
>> +                              "\"\n"
>> +                              "\nexec ")))
>
> I think it’s fine to use ‘wrap-program’ here, even if that means that
> there’s an additional wrapper layer.
>
> Unless there are performance concerns or similar, I think we should
> favor readability and maintainability.

I just pushed the commit after performing all suggested changes.
Thanks for the review!

~~ Ricardo

      reply	other threads:[~2015-03-26  8:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-16  7:13 [PATCH] Add IBus Ricardo Wurmus
2015-03-17  9:04 ` Ludovic Courtès
2015-03-26  8:09   ` Ricardo Wurmus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bnjgqixn.fsf@mango.localdomain \
    --to=ricardo.wurmus@mdc-berlin.de \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.