Re: [PATCH] Add IBus.

[Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>]

Ludovic Courtès writes:
>
>> +        (lambda* (#:key inputs outputs #:allow-other-keys)
>> +          ;; Make sure 'ibus-setup' runs with the correct PYTHONPATH and
>> +          ;; GI_TYPELIB_PATH.
>> +          (let ((out (assoc-ref outputs "out")))
>> +            (substitute* (string-append out "/bin/.ibus-setup-real")
>> +              (("exec ")
>> +               (string-append "export PYTHONPATH=\""
>> +                              (getenv "PYTHONPATH")
>> +                              "${PYTHONPATH:+:}$PYTHONPATH" "\"\n"
>> +                              "export GI_TYPELIB_PATH=\""
>> +                              (getenv "GI_TYPELIB_PATH")
>> +                              ":" out "/lib/girepository-1.0"
>> +                              "${GI_TYPELIB_PATH:+:}$GI_TYPELIB_PATH"
>> +                              "\"\n"
>> +                              "\nexec ")))
>
> I think it’s fine to use ‘wrap-program’ here, even if that means that
> there’s an additional wrapper layer.
>
> Unless there are performance concerns or similar, I think we should
> favor readability and maintainability.

I just pushed the commit after performing all suggested changes.
Thanks for the review!

~~ Ricardo