all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] services: Add console-keymap service.
Date: Wed, 29 Apr 2015 22:23:06 +0200	[thread overview]
Message-ID: <87bni6fzv9.fsf@gnu.org> (raw)
In-Reply-To: <87vbgkj6qt.fsf@gmail.com> (Alex Kost's message of "Sat, 25 Apr 2015 23:24:58 +0300")

Alex Kost <alezost@gmail.com> skribis:

> From f879481f96386617d070b146aa2c3d1988deff40 Mon Sep 17 00:00:00 2001
> From: Alex Kost <alezost@gmail.com>
> Date: Sat, 25 Apr 2015 22:52:29 +0300
> Subject: [PATCH] services: Add console-keymap service.
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> * gnu/services/base.scm (console-keymap-service): New procedure.
> * doc/guix.texi (Base Services): Document it.
>
> Co-authored-by: 宋文武 <iyzsong@gmail.com>

[...]

> +      (documentation
> +       (string-append "Load '" file "' console keymap (loadkeys)."))

Please make it a literal string, thus omitting FILE entirely.

Otherwise LGTM, please push.

Eventually, this should probably be promoted as a field in
‘operating-system’, with the service automatically added as part of
‘essential-services’.  WDYT?

Thanks to both of you!

Ludo’.

  parent reply	other threads:[~2015-04-29 20:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-25 20:24 [PATCH] services: Add console-keymap service Alex Kost
2015-04-25 23:53 ` 宋文武
2015-04-29 20:23 ` Ludovic Courtès [this message]
2015-04-30 16:22   ` Alex Kost
2015-04-30 16:37     ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bni6fzv9.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=alezost@gmail.com \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.