From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark H Weaver Subject: Re: [PATCH] gnu: python-2: update to 2.7.10. Date: Mon, 10 Aug 2015 19:45:23 -0400 Message-ID: <87bneepv1o.fsf@netris.org> References: <20150731180512.GA9619@debian> <87d1z5mpl0.fsf@netris.org> <874mkhm84k.fsf@netris.org> <87egjjt8ai.fsf@netris.org> <87zj24rm63.fsf@netris.org> <20150810135636.GA30125@debian> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37077) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZOwl8-00087g-Am for guix-devel@gnu.org; Mon, 10 Aug 2015 19:45:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZOwl4-0004tC-4g for guix-devel@gnu.org; Mon, 10 Aug 2015 19:45:38 -0400 Received: from world.peace.net ([50.252.239.5]:54673) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZOwl3-0004sV-OY for guix-devel@gnu.org; Mon, 10 Aug 2015 19:45:33 -0400 In-Reply-To: <20150810135636.GA30125@debian> (Andreas Enge's message of "Mon, 10 Aug 2015 15:56:36 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Andreas Enge Cc: guix-devel@gnu.org Hi Andreas, Andreas Enge writes: > something does not work as expected in your commit > 9f6509c655b766b0fb9dfab181a8533e698473b0 to accomodate python version > numbers with two-digit components. Now the files are installed into > lib/python.7. for python-2 modules Actually, that's precisely the problem that was fixed by 9f6509c655b766b0fb9dfab181a8533e698473b0. > (see, for instance, python2-sip). The reason it still fails for python2-sip is because python-sip contains another copy of the same faulty code that I fixed in 9f6509c655b766b0fb9dfab181a8533e698473b0: --8<---------------cut here---------------start------------->8--- (python-version (string-take (string-take-right (assoc-ref inputs "python") 5) 3)) --8<---------------cut here---------------end--------------->8--- The commit logs show that you wrote both of these pieces of code: the one above, and the one I already fixed. Please don't assume that version numbers contain only single-digit components. In Scheme we have the tools to conveniently do this job properly. I'll leave it to you to fix this instance of the bug. If you know of any other occurrences of the same bug, can you fix them also? Thanks, Mark