From: Mark H Weaver <mhw@netris.org>
To: Andreas Enge <andreas@enge.fr>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: python-2: update to 2.7.10.
Date: Mon, 10 Aug 2015 19:45:23 -0400 [thread overview]
Message-ID: <87bneepv1o.fsf@netris.org> (raw)
In-Reply-To: <20150810135636.GA30125@debian> (Andreas Enge's message of "Mon, 10 Aug 2015 15:56:36 +0200")
Hi Andreas,
Andreas Enge <andreas@enge.fr> writes:
> something does not work as expected in your commit
> 9f6509c655b766b0fb9dfab181a8533e698473b0 to accomodate python version
> numbers with two-digit components. Now the files are installed into
> lib/python.7. for python-2 modules
Actually, that's precisely the problem that was fixed by
9f6509c655b766b0fb9dfab181a8533e698473b0.
> (see, for instance, python2-sip).
The reason it still fails for python2-sip is because python-sip
contains another copy of the same faulty code that I fixed in
9f6509c655b766b0fb9dfab181a8533e698473b0:
--8<---------------cut here---------------start------------->8---
(python-version
(string-take
(string-take-right (assoc-ref inputs "python") 5)
3))
--8<---------------cut here---------------end--------------->8---
The commit logs show that you wrote both of these pieces of code: the
one above, and the one I already fixed.
Please don't assume that version numbers contain only single-digit
components. In Scheme we have the tools to conveniently do this job
properly.
I'll leave it to you to fix this instance of the bug. If you know of
any other occurrences of the same bug, can you fix them also?
Thanks,
Mark
next prev parent reply other threads:[~2015-08-10 23:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-31 18:05 Python 2.7.* Andreas Enge
2015-08-02 15:42 ` [PATCH] gnu: python-2: update to 2.7.10 eric
2015-08-02 19:56 ` Mark H Weaver
2015-08-02 22:56 ` eric
2015-08-03 2:13 ` Mark H Weaver
2015-08-03 8:59 ` Andreas Enge
2015-08-04 14:52 ` Mark H Weaver
2015-08-07 0:12 ` Mark H Weaver
2015-08-10 13:56 ` Andreas Enge
2015-08-10 23:45 ` Mark H Weaver [this message]
2015-08-11 7:35 ` Andreas Enge
2015-08-18 15:30 ` Ludovic Courtès
2015-08-18 16:23 ` Eric Dvorsak
2015-08-18 17:48 ` Eric Bavier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bneepv1o.fsf@netris.org \
--to=mhw@netris.org \
--cc=andreas@enge.fr \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.