From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <rekado@elephly.net>
Subject: Re: [PATCH] Add ibus-libpinyin.
Date: Sat, 12 Sep 2015 22:54:19 +0200
Message-ID: <87bnd79x50.fsf@elephly.net>
References: <874mj4azlf.fsf@elephly.net> <87mvwvs6fm.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54953)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1Zarog-0000tP-A7
	for guix-devel@gnu.org; Sat, 12 Sep 2015 16:54:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1Zarof-0005zi-81
	for guix-devel@gnu.org; Sat, 12 Sep 2015 16:54:34 -0400
In-reply-to: <87mvwvs6fm.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel <guix-devel@gnu.org>


Ludovic Courtès <ludo@gnu.org> writes:

> Ricardo Wurmus <rekado@elephly.net> skribis:
>
>> From 984245dcc1359c4de3ff3a26c0d1d6427a88b6fa Mon Sep 17 00:00:00 2001
>> From: Ricardo Wurmus <rekado@elephly.net>
>> Date: Wed, 9 Sep 2015 07:27:18 +0200
>> Subject: [PATCH 1/2] gnu: Add libpinyin.
>>
>> * gnu/packages/ibus.scm (libpinyin): New variable.
>
> [...]
>
>> +        ,(origin
>> +           (method url-fetch)
>> +           (uri (string-append "http://downloads.sourceforge.net/libpinyin/"
>> +                               "models/model10.text.tar.gz"))
>
> Should be mirror://sourceforge/ if possible.

Fixed.

>> +    (native-inputs
>> +     `(("pkg-config" ,pkg-config)
>> +       ("tar" ,tar)
>
> ‘tar’ can be omitted, it’s an implicit input.

Okay.

> It’s a pity that no ‘make dist’ tarball is published; that would make
> everbody’s lives easier.

Indeed.

I just pushed both updated patches.  Thanks!

~~ Ricardo