Re: [PATCH] Add ibus-libpinyin.

[Ricardo Wurmus <rekado@elephly.net>]

Ludovic Courtès <ludo@gnu.org> writes:

> Ricardo Wurmus <rekado@elephly.net> skribis:
>
>> From 984245dcc1359c4de3ff3a26c0d1d6427a88b6fa Mon Sep 17 00:00:00 2001
>> From: Ricardo Wurmus <rekado@elephly.net>
>> Date: Wed, 9 Sep 2015 07:27:18 +0200
>> Subject: [PATCH 1/2] gnu: Add libpinyin.
>>
>> * gnu/packages/ibus.scm (libpinyin): New variable.
>
> [...]
>
>> +        ,(origin
>> +           (method url-fetch)
>> +           (uri (string-append "http://downloads.sourceforge.net/libpinyin/"
>> +                               "models/model10.text.tar.gz"))
>
> Should be mirror://sourceforge/ if possible.

Fixed.

>> +    (native-inputs
>> +     `(("pkg-config" ,pkg-config)
>> +       ("tar" ,tar)
>
> ‘tar’ can be omitted, it’s an implicit input.

Okay.

> It’s a pity that no ‘make dist’ tarball is published; that would make
> everbody’s lives easier.

Indeed.

I just pushed both updated patches.  Thanks!

~~ Ricardo