all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/5] gnu: Add python-wrapt
Date: Sun, 13 Sep 2015 11:44:30 +0200	[thread overview]
Message-ID: <87bnd68xhd.fsf@gnu.org> (raw)
In-Reply-To: <1441755264-6790-1-git-send-email-tipecaml@gmail.com> (Cyril Roelandt's message of "Wed, 9 Sep 2015 01:34:20 +0200")

Cyril Roelandt <tipecaml@gmail.com> skribis:

> * gnu/packages/python.scm (python-wrapt, python2-wrapt): New variables.

[...]

> +     ;; Lots of different test configurations. TODO: run them all.
> +     `(#:tests? #f))

It’s not clear why tests are not run.  Could you clarify this in the
comment?  (Or run them if there’s no particular reason not do it.)

> +    (synopsis
> +      "Module for decorators, wrappers and monkey patching")

One line is enough.

OK with these changes!

Thanks,
Ludo’.

      parent reply	other threads:[~2015-09-13  9:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-08 23:34 [PATCH 1/5] gnu: Add python-wrapt Cyril Roelandt
2015-09-08 23:34 ` [PATCH 2/5] gnu: Add python-iso8601 Cyril Roelandt
2015-09-13  9:45   ` Ludovic Courtès
2015-09-08 23:34 ` [PATCH 3/5] gnu: Add python-monotonic Cyril Roelandt
2015-09-13  9:46   ` Ludovic Courtès
2015-09-08 23:34 ` [PATCH 4/5] gnu: Add python-debtcollector Cyril Roelandt
2015-09-13  9:49   ` Ludovic Courtès
2015-09-08 23:34 ` [PATCH 5/5] gnu: Add python-oslo.utils Cyril Roelandt
2015-09-13  9:50   ` Ludovic Courtès
2015-09-13  9:44 ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bnd68xhd.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=tipecaml@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.