From: Mathieu Lirzin <mthl@openmailbox.org>
To: Steve Sprang <steve.sprang@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] download: Fix some minor progress-logging regressions.
Date: Thu, 17 Sep 2015 20:18:49 +0200 [thread overview]
Message-ID: <87bnd0j4dy.fsf@openmailbox.org> (raw)
In-Reply-To: <CA+xn8YCbfJPCXBq0BKVnULhdxOfkFe2NR2_VoxZksyNQnuxoGw@mail.gmail.com> (Steve Sprang's message of "Thu, 17 Sep 2015 04:24:59 -0700")
Steve Sprang <steve.sprang@gmail.com> writes:
> From 11440f61cebd49d31d165f6433ec6e4b1afe728f Mon Sep 17 00:00:00 2001
> From: Steve Sprang <scs@stevesprang.com>
> Date: Thu, 17 Sep 2015 04:22:01 -0700
> Subject: [PATCH] download: Fix some minor progress-logging regressions.
>
> * guix/build/download.scm
> (string-pad-middle): Allow resulting padded string to overflow.
> (store-url-abbreviation): Remove unnecessary procedure.
> (progress-proc): Default abbreviation should be basename.
What about something like "(progress-proc): Use BASENAME as default for
parameter 'abbreviation'." ?
> (url-fetch): Insert some newlines for readability.
I would prefer "Display" instead of "Insert" to not confuse with
insertion of newlines in the source code (even if such change won't be
notified in the commit log) :)
> ---
> guix/build/download.scm | 20 +++++++++-----------
> 1 file changed, 9 insertions(+), 11 deletions(-)
>
> diff --git a/guix/build/download.scm b/guix/build/download.scm
> index 9b72e8f..e6de4d2 100644
> --- a/guix/build/download.scm
> +++ b/guix/build/download.scm
> @@ -100,15 +100,13 @@ width of the bar is BAR-WIDTH."
>
> (define (string-pad-middle left right len)
> "Combine LEFT and RIGHT with enough padding in the middle so that the
> -resulting string has length at least LEN. This right justifies RIGHT."
^^^
Maybe it's only because of my poor english but I don't understand the
meaning of the last sentence.
Otherwise this looks good to me.
--
Mathieu Lirzin
next prev parent reply other threads:[~2015-09-17 18:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 11:24 [PATCH] download: Fix some minor progress-logging regressions Steve Sprang
2015-09-17 18:18 ` Mathieu Lirzin [this message]
2015-09-17 19:44 ` Steve Sprang
2015-09-17 20:52 ` Steve Sprang
2015-09-17 21:44 ` Mathieu Lirzin
2015-09-24 0:48 ` Steve Sprang
2015-09-24 7:42 ` Ludovic Courtès
2015-09-24 2:05 ` Mark H Weaver
2015-09-17 21:21 ` Mathieu Lirzin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bnd0j4dy.fsf@openmailbox.org \
--to=mthl@openmailbox.org \
--cc=guix-devel@gnu.org \
--cc=steve.sprang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.