From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH] gnu: sdl-union: Wrap into a procedure and export it. Date: Mon, 12 Oct 2015 11:54:41 +0300 Message-ID: <87bnc4cvqm.fsf@gmail.com> References: <87wpv2jvgr.fsf@gmail.com> <87oag8qkp8.fsf@gnu.org> <87twpz4sff.fsf@gnu.org> <87lhbbrtw3.fsf_-_@gmail.com> <87r3l12vts.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51361) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlYsY-0005ap-B8 for guix-devel@gnu.org; Mon, 12 Oct 2015 04:54:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZlYsV-00053e-KO for guix-devel@gnu.org; Mon, 12 Oct 2015 04:54:46 -0400 List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel Ludovic Court=C3=A8s (2015-10-11 19:50 +0300) wrote: > Alex Kost skribis: > >> +(define (sdl-union . sdl-packages) >> + "Return 'sdl-union' package that is the union of SDL-PACKAGES. >> +If SDL-PACKAGES are not specified, all SDL libraries are used." >> + (let* ((sdl-packages (if (null? sdl-packages) >> + (list sdl >> + sdl-gfx >> + sdl-image >> + sdl-mixer >> + sdl-net >> + sdl-ttf) >> + sdl-packages)) > > What about writing it like this: > > (define* (sdl-union #:optional (packages (list sdl sdl-gfx =E2=80=A6))) > =E2=80=A6) > > That would be more concise and more idiomatic. > > If that=E2=80=99s fine with you, OK to push with this change. Sure, fixed and pushed, thanks ! --=20 Alex