From: Paul van der Walt <paul@denknerd.org>
To: ericbavier@openmailbox.org
Cc: guix-devel@gnu.org
Subject: Re: Reviews for wip-haskell-platform-7.10.2-a
Date: Thu, 22 Oct 2015 12:27:16 +0200 [thread overview]
Message-ID: <87bnbrryez.fsf@denknerd.org> (raw)
In-Reply-To: <1445483479-19104-1-git-send-email-ericbavier@openmailbox.org>
Hey Eric,
Thank you for all the review-work!
On 2015-10-22 at 05:10, quoth ericbavier@openmailbox.org:
> I apologize in advance that so many of these comments pertain to the synopses
> and descriptions, but I find that aspect of packaging important, and Ludo was
> kind enough to write up the "Synopses and Descriptions" section in guix.info.
I guess that's the way it should be. I admit that my descriptions are
often shoddy simply because i wasn't sure what the library does. But of
course that's no excuse to not follow the style (e.g., sentence
fragments, formatting).
> Along the way I gave up trying to analyse and comment on inputs vs
> propagated-inputs. The builds check out, and we can adjust later if needed.
Right. I tried to be conservative with propagated-inputs, but at least
they all work... I'm curious to see how the library search path patch
will influence things.
> In the absense of comments on a patch, assume a "LGTM!" :)
Okay, well, i'll deal with all the comments before merging anything.
> Thank you, Paul for all the effort,
Seems you went to a lot of effort too, thank you for your thorough
reviews!
On to a more Haskell-friendly Guix! :)
Cheers,
p.
prev parent reply other threads:[~2015-10-22 10:27 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-22 3:10 Reviews for wip-haskell-platform-7.10.2-a ericbavier
2015-10-22 3:10 ` [PATCH] gnu: Add ghc-attoparsec ericbavier
2015-10-22 10:40 ` Paul van der Walt
2015-10-22 3:10 ` [PATCH] gnu: Add ghc-base64-bytestring ericbavier
2015-10-22 10:44 ` Paul van der Walt
2015-10-22 3:18 ` [PATCH] gnu: Add ghc-blaze-builder ericbavier
2015-10-22 3:18 ` [PATCH] gnu: Add ghc-blaze-markup ericbavier
2015-10-22 10:54 ` Paul van der Walt
2015-10-22 3:18 ` [PATCH] gnu: Add ghc-bytestring-builder ericbavier
2015-10-22 11:01 ` Paul van der Walt
2015-10-22 11:02 ` [PATCH] gnu: Add ghc-blaze-builder Paul van der Walt
2015-10-22 3:25 ` [PATCH] gnu: Add ghc-cereal ericbavier
2015-10-22 3:25 ` [PATCH] gnu: Add ghc-clock ericbavier
2015-10-22 13:57 ` Paul van der Walt
2015-10-22 3:25 ` [PATCH] gnu: Add ghc-cpphs ericbavier
2015-10-22 11:20 ` Paul van der Walt
2015-10-22 11:25 ` [PATCH] gnu: Add ghc-cereal Paul van der Walt
2015-10-22 3:32 ` [PATCH] gnu: Add ghc-doctest ericbavier
2015-10-22 3:32 ` [PATCH] gnu: Add ghc-fingertree ericbavier
2015-10-22 11:27 ` Paul van der Walt
2015-10-22 3:32 ` [PATCH] gnu: Add ghc-free ericbavier
2015-10-22 11:28 ` Paul van der Walt
2015-10-22 12:58 ` [PATCH] gnu: Add ghc-doctest Paul van der Walt
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-gluraw ericbavier
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-haddock-api ericbavier
2015-10-22 15:20 ` Paul van der Walt
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-haskell-src-exts ericbavier
2015-10-22 14:07 ` Paul van der Walt
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-hlint ericbavier
2015-10-22 15:15 ` Paul van der Walt
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-hscolour ericbavier
2015-10-22 15:17 ` Paul van der Walt
2015-10-22 16:48 ` Eric Bavier
2015-10-22 16:53 ` Paul van der Walt
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-opengl ericbavier
2015-10-22 15:10 ` Paul van der Walt
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-openglraw ericbavier
2015-10-22 15:07 ` Paul van der Walt
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-pcre-light ericbavier
2015-10-22 15:06 ` Paul van der Walt
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-reflection ericbavier
2015-10-22 15:04 ` Paul van der Walt
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-regex-base ericbavier
2015-10-22 15:03 ` Paul van der Walt
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-regex-posix ericbavier
2015-10-22 15:01 ` Paul van der Walt
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-regex-tdfa-rc ericbavier
2015-10-22 15:00 ` Paul van der Walt
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-sdl-mixer ericbavier
2015-10-22 16:04 ` Paul van der Walt
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-semigroupoids ericbavier
2015-10-22 14:57 ` Paul van der Walt
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-semigroups ericbavier
2015-10-22 14:15 ` Paul van der Walt
2015-10-22 16:54 ` Eric Bavier
2015-10-22 14:56 ` Paul van der Walt
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-tasty-golden ericbavier
2015-10-22 14:54 ` Paul van der Walt
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-uniplate ericbavier
2015-10-22 14:52 ` Paul van der Walt
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-unix-time ericbavier
2015-10-22 15:43 ` Paul van der Walt
2015-10-22 16:22 ` Andreas Enge
2015-10-22 16:50 ` Paul van der Walt
2015-10-22 16:57 ` Eric Bavier
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-wai ericbavier
2015-10-22 14:50 ` Paul van der Walt
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-xml ericbavier
2015-10-22 14:48 ` Paul van der Walt
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-zip-archive ericbavier
2015-10-22 14:47 ` Paul van der Walt
2015-10-22 8:47 ` [PATCH] gnu: Add Idris, the dependently-typed language ericbavier
2015-10-22 14:45 ` Paul van der Walt
2015-10-22 17:02 ` Eric Bavier
2015-10-22 17:20 ` Paul van der Walt
2015-10-22 8:47 ` [PATCH] gnu: ghc-split: Update dependencies ericbavier
2015-10-22 16:16 ` Paul van der Walt
2015-10-22 17:06 ` Eric Bavier
2015-10-22 17:26 ` Paul van der Walt
2015-10-22 14:21 ` [PATCH] gnu: Add ghc-gluraw Paul van der Walt
2015-10-22 10:27 ` Paul van der Walt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bnbrryez.fsf@denknerd.org \
--to=paul@denknerd.org \
--cc=ericbavier@openmailbox.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.