From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark H Weaver <mhw@netris.org>
Subject: Re: [PATCH] gnu: Add dosbox x86 emulator.
Date: Wed, 21 Oct 2015 18:40:33 -0400
Message-ID: <87bnbrn8v2.fsf@netris.org>
References: <1445261129-27744-1-git-send-email-paul@denknerd.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41085)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1Zp241-00074N-OO
	for guix-devel@gnu.org; Wed, 21 Oct 2015 18:40:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1Zp23w-0007Tf-Ta
	for guix-devel@gnu.org; Wed, 21 Oct 2015 18:40:57 -0400
Received: from world.peace.net ([50.252.239.5]:46209)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1Zp23w-0007TD-P9
	for guix-devel@gnu.org; Wed, 21 Oct 2015 18:40:52 -0400
In-Reply-To: <1445261129-27744-1-git-send-email-paul@denknerd.org> (Paul van
	der Walt's message of "Mon, 19 Oct 2015 15:25:29 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Paul van der Walt <paul@denknerd.org>
Cc: guix-devel@gnu.org

Hi Paul,

Paul van der Walt <paul@denknerd.org> writes:
> +(define-public dosbox
> +  (package
> +    (name "dosbox")
> +    (version "0.74")
> +    (source (origin
> +              (method svn-fetch)
> +              (uri (svn-reference
> +                    (url "http://svn.code.sf.net/p/dosbox/code-0/dosbox/trunk/")
> +                    (revision 3947)))
> +              ;; Using SVN head, since the last release (2010) is incompatible
> +              ;; with GCC5 (see
> +              ;; <https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=624976>).
> +              (sha256
> +               (base32
> +                "1p918j6090d1nkvgq7ifvmn506zrdmyi32y7p3ms40d5ssqjg8fj"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:phases (modify-phases %standard-phases
> +                  (add-before
> +                   'configure 'autogen.sh
> +                   (lambda _
> +                     (zero? (system* "sh" "autogen.sh")))))))

For future reference, phases like the one above, that generates the
configure script, should always be put after 'unpack' instead of before
'configure'.  The reason is that there are some phases between the
'unpack' and 'configure' phases that are needed to fix things up in the
generated 'configure' script for non-Intel platforms, especially
'patch-usr-bin-file' which is typically needed on MIPS.

I went ahead and made this change in commit e0a7d36458.

    Regards,
      Mark