From: Mark H Weaver <mhw@netris.org>
To: Paul van der Walt <paul@denknerd.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add dosbox x86 emulator.
Date: Wed, 21 Oct 2015 18:40:33 -0400 [thread overview]
Message-ID: <87bnbrn8v2.fsf@netris.org> (raw)
In-Reply-To: <1445261129-27744-1-git-send-email-paul@denknerd.org> (Paul van der Walt's message of "Mon, 19 Oct 2015 15:25:29 +0200")
Hi Paul,
Paul van der Walt <paul@denknerd.org> writes:
> +(define-public dosbox
> + (package
> + (name "dosbox")
> + (version "0.74")
> + (source (origin
> + (method svn-fetch)
> + (uri (svn-reference
> + (url "http://svn.code.sf.net/p/dosbox/code-0/dosbox/trunk/")
> + (revision 3947)))
> + ;; Using SVN head, since the last release (2010) is incompatible
> + ;; with GCC5 (see
> + ;; <https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=624976>).
> + (sha256
> + (base32
> + "1p918j6090d1nkvgq7ifvmn506zrdmyi32y7p3ms40d5ssqjg8fj"))))
> + (build-system gnu-build-system)
> + (arguments
> + `(#:phases (modify-phases %standard-phases
> + (add-before
> + 'configure 'autogen.sh
> + (lambda _
> + (zero? (system* "sh" "autogen.sh")))))))
For future reference, phases like the one above, that generates the
configure script, should always be put after 'unpack' instead of before
'configure'. The reason is that there are some phases between the
'unpack' and 'configure' phases that are needed to fix things up in the
generated 'configure' script for non-Intel platforms, especially
'patch-usr-bin-file' which is typically needed on MIPS.
I went ahead and made this change in commit e0a7d36458.
Regards,
Mark
next prev parent reply other threads:[~2015-10-21 22:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 13:25 [PATCH] gnu: Add dosbox x86 emulator Paul van der Walt
2015-10-21 19:41 ` Ludovic Courtès
2015-10-21 20:12 ` Paul van der Walt
2015-10-21 22:40 ` Mark H Weaver [this message]
2015-10-22 9:13 ` Paul van der Walt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bnbrn8v2.fsf@netris.org \
--to=mhw@netris.org \
--cc=guix-devel@gnu.org \
--cc=paul@denknerd.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.