Re: [PATCH] gnu: Add dosbox x86 emulator.

[Mark H Weaver <mhw@netris.org>]

Hi Paul,

Paul van der Walt <paul@denknerd.org> writes:
> +(define-public dosbox
> +  (package
> +    (name "dosbox")
> +    (version "0.74")
> +    (source (origin
> +              (method svn-fetch)
> +              (uri (svn-reference
> +                    (url "http://svn.code.sf.net/p/dosbox/code-0/dosbox/trunk/")
> +                    (revision 3947)))
> +              ;; Using SVN head, since the last release (2010) is incompatible
> +              ;; with GCC5 (see
> +              ;; <https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=624976>).
> +              (sha256
> +               (base32
> +                "1p918j6090d1nkvgq7ifvmn506zrdmyi32y7p3ms40d5ssqjg8fj"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:phases (modify-phases %standard-phases
> +                  (add-before
> +                   'configure 'autogen.sh
> +                   (lambda _
> +                     (zero? (system* "sh" "autogen.sh")))))))

For future reference, phases like the one above, that generates the
configure script, should always be put after 'unpack' instead of before
'configure'.  The reason is that there are some phases between the
'unpack' and 'configure' phases that are needed to fix things up in the
generated 'configure' script for non-Intel platforms, especially
'patch-usr-bin-file' which is typically needed on MIPS.

I went ahead and made this change in commit e0a7d36458.

    Regards,
      Mark