From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Wingo Subject: Re: [PATCH 1/7] guix: git: Support shallow git clones if a tag is available Date: Mon, 26 Oct 2015 07:46:56 +0000 Message-ID: <87bnbmax73.fsf@igalia.com> References: <1439893929.575691.5108@rusty> <876143o49y.fsf@gnu.org> <87twplin1u.fsf@dustycloud.org> <87y4eqk54g.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53624) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZqcVJ-0003g1-6w for guix-devel@gnu.org; Mon, 26 Oct 2015 03:47:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZqcVE-0007EL-Qi for guix-devel@gnu.org; Mon, 26 Oct 2015 03:47:41 -0400 In-Reply-To: <87y4eqk54g.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Sun, 25 Oct 2015 22:30:55 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org Hi, On Sun 25 Oct 2015 21:30, ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Christopher Allan Webber skribis: > >> Ludovic Court=C3=A8s writes: >> >>> Andy Wingo skribis: >>> >>>> * guix/build/git.scm (git-fetch): Instead of cloning the remote repo, = use the >>>> lower-level "init" / "fetch" / "checkout" operations. This lets us = make a >>>> shallow checkout if we are checking out a tag. >>>> >>>> * guix/git-download.scm (): Add tag field. >>>> (git-fetch): Support git references with tags but no commits. >>> >>> This sounds like a nice improvement. Please move the =E2=80=9CThis let= s us=E2=80=9D >>> sentence to a comment, and drop the newline between entries. >> >> This does look like a nice improvement! It seems like it kind of got >> dropped on the floor. Is there still interest? > > Yes! Would you like to look into it? :-) I can do it :) I just rebased and updated after a couple months, and so I have the patch fresh :) Sorry for the delay; I am a creature of habit and using Guix on the machine with that patch broke all my habits :P Andy