all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Andy Wingo <wingo@igalia.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/7] guix: git: Support shallow git clones if a tag is available
Date: Mon, 26 Oct 2015 07:46:56 +0000	[thread overview]
Message-ID: <87bnbmax73.fsf@igalia.com> (raw)
In-Reply-To: <87y4eqk54g.fsf@gnu.org> ("Ludovic Courtès"'s message of "Sun, 25 Oct 2015 22:30:55 +0100")

Hi,

On Sun 25 Oct 2015 21:30, ludo@gnu.org (Ludovic Courtès) writes:

> Christopher Allan Webber <cwebber@dustycloud.org> skribis:
>
>> Ludovic Courtès writes:
>>
>>> Andy Wingo <wingo@igalia.com> skribis:
>>>
>>>> * guix/build/git.scm (git-fetch): Instead of cloning the remote repo, use the
>>>>   lower-level "init" / "fetch" / "checkout" operations.  This lets us make a
>>>>   shallow checkout if we are checking out a tag.
>>>>
>>>> * guix/git-download.scm (<git-reference>): Add tag field.
>>>>   (git-fetch): Support git references with tags but no commits.
>>>
>>> This sounds like a nice improvement.  Please move the “This lets us”
>>> sentence to a comment, and drop the newline between entries.
>>
>> This does look like a nice improvement!  It seems like it kind of got
>> dropped on the floor.  Is there still interest?
>
> Yes!  Would you like to look into it?  :-)

I can do it :)  I just rebased and updated after a couple months, and so
I have the patch fresh :)  Sorry for the delay; I am a creature of habit
and using Guix on the machine with that patch broke all my habits :P

Andy

  reply	other threads:[~2015-10-26  7:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-18  8:03 [PATCH 1/7] guix: git: Support shallow git clones if a tag is available Andy Wingo
2015-08-25 14:02 ` Ludovic Courtès
2015-10-20 15:20   ` Christopher Allan Webber
2015-10-25 21:30     ` Ludovic Courtès
2015-10-26  7:46       ` Andy Wingo [this message]
2017-02-02 20:33   ` ng0
  -- strict thread matches above, loose matches on Subject: below --
2015-08-18  8:03 Andy Wingo
2015-08-18  8:03 Andy Wingo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bnbmax73.fsf@igalia.com \
    --to=wingo@igalia.com \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.