From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] import: Move beautify description from cran to utils.
Date: Mon, 18 Jan 2016 10:45:07 +0100
Message-ID: <87bn8jjk64.fsf@gnu.org>
References: <CAKrPhPNBb2FoSGNM9cPgQe2i=7RQcKJyx6gzPo+4QW+SFO0KvQ@mail.gmail.com>
	<56847D01.3010702@uq.edu.au> <87y4cb9c7a.fsf@elephly.net>
	<87y4ca18h3.fsf@gmail.com> <87si2haepb.fsf@mdc-berlin.de>
	<56863A6B.90809@uq.edu.au> <87r3i19w8s.fsf@mdc-berlin.de>
	<568BD248.5090309@uq.edu.au> <87h9ilyw1b.fsf@gnu.org>
	<56976F1B.8010405@uq.edu.au> <87k2nc310w.fsf@mdc-berlin.de>
	<56977E47.50104@uq.edu.au>
	<idjbn8oflei.fsf@bimsb-sys02.mdc-berlin.net>
	<56979165.2080304@uq.edu.au> <569AE7AF.80400@uq.edu.au>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49594)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1aL6NH-00010C-Ib
	for guix-devel@gnu.org; Mon, 18 Jan 2016 04:45:24 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1aL6NG-0001T2-8e
	for guix-devel@gnu.org; Mon, 18 Jan 2016 04:45:23 -0500
In-Reply-To: <569AE7AF.80400@uq.edu.au> (Ben Woodcroft's message of "Sun, 17
	Jan 2016 11:00:31 +1000")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ben Woodcroft <b.woodcroft@uq.edu.au>
Cc: Guix-devel <guix-devel@gnu.org>, Alex Kost <alezost@gmail.com>, Federico Beffa <beffa@ieee.org>

Ben Woodcroft <b.woodcroft@uq.edu.au> skribis:

> From 06f3c311ccab7013b030bb919a1cf40054fe9263 Mon Sep 17 00:00:00 2001
> From: Ben Woodcroft <donttrustben@gmail.com>
> Date: Sun, 17 Jan 2016 10:20:59 +1000
> Subject: [PATCH 2/2] tests: Move beatify-description tests to import-tests.
>
> * tests/cran.scm (beautify-description: use double spacing,
> beautify-description: transform fragment into sentence). Move
> from here ...
> * tests/import-utils.scm: ... to here. New file.
> * Makefile.am (SCM_TESTS): Add import-utils.

[...]

> +++ b/tests/import-utils.scm
> @@ -0,0 +1,38 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright .© 2016 Ben Woodcroft <donttrustben@gmail.com>

Please keep the line for Ricardo.

> +(define-module (test-import-utils)
> +  #:use-module (guix tests)
> +  #:use-module (srfi srfi-64))
> +
> +(test-begin "import-utils")
> +
> +(test-equal "beautify-description: use double spacing"
> +  "This is a package.  It is great.  Trust me Mr.  Hendrix."
> +  ((@@ (guix import utils) beautify-description)

Since ‘beautify-description’ is now exported, could you add
#:use-module (guix import utils) and remove the ‘@@’ form?

> +(test-equal "beautify-description: transform fragment into sentence"
> +  "This package provides a function to establish world peace"
> +  ((@@ (guix import utils) beautify-description)

Same here.

OK with this change.

> From 999bbb38b868a0ae018e631debf5a3ca6e91f065 Mon Sep 17 00:00:00 2001
> From: Ben Woodcroft <donttrustben@gmail.com>
> Date: Sun, 17 Jan 2016 09:12:14 +1000
> Subject: [PATCH 1/2] import: gem: Beautify only the description, not the
>  synopsis.
>
> * guix/import/gem.scm (make-gem-sexp): Add synopsis argument.
> (gem->guix-package): Pass unbeautified synopsis to make-gem-sexp.
> * tests/gem.scm: Adapt it.

Please also add:

  Fixes <http://bugs.gnu.org/22391>.

below the subject line.

OK with this change.

Thanks!

Ludo’.