Re: [PATCH] import: Move beautify description from cran to utils.

[ludo@gnu.org (Ludovic Courtès)]

Ben Woodcroft <b.woodcroft@uq.edu.au> skribis:

> From 06f3c311ccab7013b030bb919a1cf40054fe9263 Mon Sep 17 00:00:00 2001
> From: Ben Woodcroft <donttrustben@gmail.com>
> Date: Sun, 17 Jan 2016 10:20:59 +1000
> Subject: [PATCH 2/2] tests: Move beatify-description tests to import-tests.
>
> * tests/cran.scm (beautify-description: use double spacing,
> beautify-description: transform fragment into sentence). Move
> from here ...
> * tests/import-utils.scm: ... to here. New file.
> * Makefile.am (SCM_TESTS): Add import-utils.

[...]

> +++ b/tests/import-utils.scm
> @@ -0,0 +1,38 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright .© 2016 Ben Woodcroft <donttrustben@gmail.com>

Please keep the line for Ricardo.

> +(define-module (test-import-utils)
> +  #:use-module (guix tests)
> +  #:use-module (srfi srfi-64))
> +
> +(test-begin "import-utils")
> +
> +(test-equal "beautify-description: use double spacing"
> +  "This is a package.  It is great.  Trust me Mr.  Hendrix."
> +  ((@@ (guix import utils) beautify-description)

Since ‘beautify-description’ is now exported, could you add
#:use-module (guix import utils) and remove the ‘@@’ form?

> +(test-equal "beautify-description: transform fragment into sentence"
> +  "This package provides a function to establish world peace"
> +  ((@@ (guix import utils) beautify-description)

Same here.

OK with this change.

> From 999bbb38b868a0ae018e631debf5a3ca6e91f065 Mon Sep 17 00:00:00 2001
> From: Ben Woodcroft <donttrustben@gmail.com>
> Date: Sun, 17 Jan 2016 09:12:14 +1000
> Subject: [PATCH 1/2] import: gem: Beautify only the description, not the
>  synopsis.
>
> * guix/import/gem.scm (make-gem-sexp): Add synopsis argument.
> (gem->guix-package): Pass unbeautified synopsis to make-gem-sexp.
> * tests/gem.scm: Adapt it.

Please also add:

  Fixes <http://bugs.gnu.org/22391>.

below the subject line.

OK with this change.

Thanks!

Ludo’.