From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christopher Allan Webber <cwebber@dustycloud.org>
Subject: Re: [PATCH 3/18] gnu: Add python2-apipkg.
Date: Sun, 21 Feb 2016 18:52:12 -0800
Message-ID: <87bn794ftv.fsf@dustycloud.org>
References: <87mvr1sgfu.fsf@dustycloud.org> <20160216013725.GE3984@jasmine>
	<87lh6gnmec.fsf@dustycloud.org> <20160220043204.GA14995@jasmine>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33572)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cwebber@dustycloud.org>) id 1aXgbi-0008Ux-Eg
	for guix-devel@gnu.org; Sun, 21 Feb 2016 21:52:19 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <cwebber@dustycloud.org>) id 1aXgbe-0000r4-6L
	for guix-devel@gnu.org; Sun, 21 Feb 2016 21:52:18 -0500
Received: from dustycloud.org ([50.116.34.160]:49254)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cwebber@dustycloud.org>) id 1aXgbd-0000qL-Sh
	for guix-devel@gnu.org; Sun, 21 Feb 2016 21:52:14 -0500
In-reply-to: <20160220043204.GA14995@jasmine>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org

Leo Famulari writes:

> On Fri, Feb 19, 2016 at 06:30:35PM -0800, Christopher Allan Webber wrote:
>> New version.
>> 
>
>> From 03f8891a2635b6d8f349af0809547e75b9c0e112 Mon Sep 17 00:00:00 2001
>> From: Christopher Allan Webber <cwebber@dustycloud.org>
>> Date: Sat, 13 Feb 2016 18:04:18 -0800
>> Subject: [PATCH 02/18] gnu: Add python2-apipkg.
>> 
>> * gnu/packages/python.scm (python2-apipkg): New variable.
>> ---
>>  gnu/packages/python.scm | 10 +++++++++-
>>  1 file changed, 9 insertions(+), 1 deletion(-)
>> 
>> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
>> index 561f64a..ef91754 100644
>> --- a/gnu/packages/python.scm
>> +++ b/gnu/packages/python.scm
>> @@ -6852,7 +6852,15 @@ applications.")
>>  package and greatly reduce the number of imports for your users.  It is a small
>>  pure Python module that works on virtually all Python versions.")
>>      (home-page "https://bitbucket.org/hpk42/apipkg")
>> -    (license license:expat)))
>> +    (license license:expat)
>> +    (properties `((python2-variant . ,(delay python2-apipkg))))))
>> +
>> +(define-public python2-apipkg
>> +  (package
>> +    (inherit (package-with-python2
>> +              (strip-python2-variant python-apipkg)))
>> +    (native-inputs
>> +     `(("python2-setuptools" ,python2-setuptools)))))
>
> I noticed that python-apipkg uses unzip as a native-input, so this
> variant would lose unzip. I tested it python-apipkg and it doesn't
> *actually* need unzip to build... not sure why I thought it did. Would
> you mind removing unzip from python-apipkg?

Sure, though I think that's a separate commit.  I've verified it works
locally, and will push with the wip-mediagoblin changes.