From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Subject: bug#22633: Provide a kvm-less qemu / guix system vm Date: Mon, 22 Feb 2016 22:09:36 +0100 Message-ID: <87bn78moz3.fsf@gnu.org> References: <87oabnqhv3.fsf@dustycloud.org> <20160211225009.GA4943@novena-choice-citizen.lan> <87oabm2tfa.fsf@gnu.org> <87ziv595xb.fsf@dustycloud.org> <87twl2xo6c.fsf@gnu.org> <87si0k8th9.fsf@dustycloud.org> <87r3g48rnh.fsf@dustycloud.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59322) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXxk5-0004XI-21 for bug-guix@gnu.org; Mon, 22 Feb 2016 16:10:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aXxk1-0005Z3-P5 for bug-guix@gnu.org; Mon, 22 Feb 2016 16:10:04 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:41418) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXxk1-0005Yz-LH for bug-guix@gnu.org; Mon, 22 Feb 2016 16:10:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aXxk1-0006ne-I4 for bug-guix@gnu.org; Mon, 22 Feb 2016 16:10:01 -0500 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <87r3g48rnh.fsf@dustycloud.org> (Christopher Allan Webber's message of "Mon, 22 Feb 2016 11:35:30 -0800") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org To: Christopher Allan Webber Cc: 22633@debbugs.gnu.org Christopher Allan Webber skribis: > Christopher Allan Webber writes: > >> Ludovic Court=C3=A8s writes: >> >>> Libkmod honors =E2=80=98modprobe.blacklist=E2=80=99 (in =E2=80=98kcmdli= ne_parse_result=E2=80=99 in >>> libkmod-config.c) and eudev passes KMOD_PROBE_APPLY_BLACKLIST >>> unconditionally in udev-builtin-kmod.c (meaning it honors it too.) >>> >>> However, there=E2=80=99s a hyphen-vs-underscore issue, I think. Namely= , the >>> file is called =E2=80=98kvm-intel.ko=E2=80=99, but the normalized modul= e name is >>> =E2=80=98kvm_intel=E2=80=99, and this is what libkmod expects (commit 5= c7dd5a changes >>> our code to normalize module names similarly.) >>> >>> Could you try with =E2=80=9Cmodprobe.blacklist=3Dkvm_intel=E2=80=9D? >> >> I tried it, and it works! This does mean that /dev/kvm doesn't exist, >> so I should be able to write a patch to Guix that disables kvm for qemu >> when /dev/kvm is absent. Great! :) > > This is slightly based off of Leo's preliminary patch, so I included him > in the copyright headers. I've tested and it works (in terms of > disabling kvm if no /dev/kvm is present) here. Cool! Can you just double-check whether -enable-kvm has any effect when /dev/kvm is missing? If it has no effect when /dev/kvm is missing, then we don=E2=80=99t even need a patch. > Let me know if I need to fix something or if I should push... > > From 852e0049213a0a80cacdcad4aba13ab242c3fbd8 Mon Sep 17 00:00:00 2001 > From: Christopher Allan Webber > Date: Mon, 22 Feb 2016 11:23:14 -0800 > Subject: [PATCH] vm: Only pass "-enable-kvm" to qemu if /dev/kvm is prese= nt. > > * gnu/build/vm.scm (load-in-linux-vm): Only pass "-enable-kvm" flag to qe= mu > if "/dev/kvm" is present. > * gnu/system/vm.scm (common-kvm-options): Same as above. [...] > + ;; Only enable kvm if we see /dev/kvm exists. > + ;; This allows uers without hardware virtualization t= o still use these ^^ Typo. [...] > + ;; Only enable kvm if we see /dev/kvm exists. > + ;; This allows uers without hardware virtualization to still use th= ese Ditto. Otherwise the patch LGTM. Make sure to mention: Fixes . in the commit log. Thanks, Ludo=E2=80=99.