From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Kost Subject: Re: [PATCH 04/13] utils: Use '@' for separating package names and version numbers. Date: Fri, 04 Mar 2016 13:19:39 +0300 Message-ID: <87bn6uee9w.fsf@gmail.com> References: <1453666771-16869-1-git-send-email-mthl@gnu.org> <1453666771-16869-5-git-send-email-mthl@gnu.org> <87h9i1evp5.fsf@gmail.com> <8737tl4bve.fsf@gnu.org> <877fiwpayr.fsf@gnu.org> <87k2m0cto5.fsf@gnu.org> <87vb5flm0q.fsf@gnu.org> <87wppo1hso.fsf@gnu.org> <87k2ljzwf6.fsf@gmail.com> <87wppjbix9.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48876) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abmpc-0005w5-Vw for guix-devel@gnu.org; Fri, 04 Mar 2016 05:19:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1abmpX-0005cr-Sw for guix-devel@gnu.org; Fri, 04 Mar 2016 05:19:36 -0500 In-Reply-To: <87wppjbix9.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Thu, 03 Mar 2016 17:55:14 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org Ludovic Court=C3=A8s (2016-03-03 19:55 +0300) wrote: > Alex Kost skribis: > >> Sorry if it was discussed but why 'package-full-name' from (guix >> packages) wasn't changed? > > I think I was afraid that existing uses in unexpected place would break, > such as when using the full name as anchor names in HTML. > > But then I also remember a version of =E2=80=98package-full-name=E2=80=99= that took an > optional separator that defaulted to =E2=80=98@=E2=80=99. I forgot the d= etails! :-) > I don=E2=80=99t think it=E2=80=99s crucial though. WDYT? I don't have an opinion on changing 'package-full-name' as I have no idea what may be broken after this change. As there are no visible breaks now, it can be left unchanged I believe. >> Also I have a question regarding hydra. Will hydra jobs still have >> such names as "git-2.6.3" or will they also be changed to "git@2.6.3"? > > I would leave them unchanged. Great, that's what I thought, thanks! >> From 2dbfe087905cc08715bba0f4d4dd0093fd93372b Mon Sep 17 00:00:00 2001 >> From: Alex Kost >> Date: Thu, 3 Mar 2016 12:53:03 +0300 >> Subject: [PATCH 1/2] emacs: Use '@' to separate package names and version >> numbers. >> >> This is a followup to commit 1b846da8c372bee78851439fd9e72b2499115e5a. >> >> * emacs/guix-base.el (guix-package-name-specification): Use "@" instead >> of "-". >> * emacs/guix-main.scm (name+version->full-name): Likewise. >> (package-inputs-names): Use 'make-package-specification' instead of >> 'package-full-name'. >> (full-name->name+version): Update the docstring. >> * emacs/guix-ui-package.el (guix-packages-by-name): Likewise. > > Looks good. I forgot about these places where the =E2=80=9Cfull name=E2= =80=9D matters, > sorry about that. It's not your fault, I didn't remember about this place either :-) >> From c6825b189f7b5d908c5fbe36d933fbe187cbc4bd Mon Sep 17 00:00:00 2001 >> From: Alex Kost >> Date: Thu, 3 Mar 2016 12:55:21 +0300 >> Subject: [PATCH 2/2] emacs: hydra: Use '-' to separate job names and ver= sion >> numbers. >> >> * emacs/guix-hydra.el (guix-hydra-job-name-specification): New procedure. >> * emacs/guix-ui-package.el (guix-package-info-insert-systems) >> (guix-package-list-latest-builds): Use it. > > OK! Thanks! I have committed both patches. --=20 Alex