From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#23200: XFCE: selecting a style has no effect
Date: Tue, 05 Apr 2016 10:11:01 +0200
Message-ID: <87bn5oxyp6.fsf@gnu.org>
References: <87oa9r65w6.fsf@gmail.com> <87vb3zyykp.fsf@elephly.net>
	<87y48us0wr.fsf@gmail.com> <871t6ldss0.fsf@gnu.org>
	<87wpod9hac.fsf@gnu.org> <87d1q4661o.fsf@gmail.com>
	<20160405065424.GA28317@novena-choice-citizen.lan>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33431)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1anM5n-00016M-Uo
	for bug-guix@gnu.org; Tue, 05 Apr 2016 04:12:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1anM5i-0002oi-9p
	for bug-guix@gnu.org; Tue, 05 Apr 2016 04:12:07 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:54521)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1anM5i-0002oe-6L
	for bug-guix@gnu.org; Tue, 05 Apr 2016 04:12:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1anM5i-00084O-0a
	for bug-guix@gnu.org; Tue, 05 Apr 2016 04:12:02 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.23200.D23200.145984387830969@debbugs.gnu.org>
In-Reply-To: <20160405065424.GA28317@novena-choice-citizen.lan> (Jookia's
	message of "Tue, 5 Apr 2016 16:54:24 +1000")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
To: Jookia <166291@gmail.com>
Cc: 23200-done@debbugs.gnu.org

Jookia <166291@gmail.com> skribis:

> On Mon, Apr 04, 2016 at 09:19:47PM -0700, Chris Marusich wrote:
>> ludo@gnu.org (Ludovic Court=C3=A8s) writes:
>>=20
>> > ludo@gnu.org (Ludovic Court=C3=A8s) skribis:
>> >
>> >> I=E2=80=99ve tested that with this patch changing colors under the =
=E2=80=9CStyle=E2=80=9D tab
>> >> in Xfce does have an effect.
>> >>
>> >> I=E2=80=99ll commit it shortly if there are no objections.
>> >
>> > Pushed a slightly different version as
>> > ae05e366bea4517f1e428799f00f11997ccef661.
>>=20
>> This fixed the issue for me.  Thanks!
>>=20
>> --=20
>> Chris
>
> I heavily disagree with this approach for two reasons:
>
> 1) It doesn't work with user theme installs.

Right, it=E2=80=99s mostly a hack to fix the immediate issue, which probably
covers many use cases since =E2=80=98xfce-desktop-service=E2=80=99 and
=E2=80=98gnome-desktop-service=E2=80=99 install things globally.

> 2) I have a patch that fixes this problem completely.
> 3) The fix I provided has been duplicated upstream in GTK+.
>
> I suggest reverting this and applying my patch and read the full breakdow=
n of
> the issue and solution here:
>
> https://lists.gnu.org/archive/html/guix-devel/2016-03/msg00492.html

Oh, I had overlooked this one, sorry about that!

Ricardo raised some concerns in that thread, namely that the patch
hard-codes a specific profile name as well.  Did you have a chance to
look into it?

Thanks for the heads-up, and my apologies for overlooking it!

Ludo=E2=80=99.