From: ludo@gnu.org (Ludovic Courtès)
To: Jookia <166291@gmail.com>
Cc: 23200-done@debbugs.gnu.org
Subject: bug#23200: XFCE: selecting a style has no effect
Date: Tue, 05 Apr 2016 10:11:01 +0200 [thread overview]
Message-ID: <87bn5oxyp6.fsf@gnu.org> (raw)
In-Reply-To: <20160405065424.GA28317@novena-choice-citizen.lan> (Jookia's message of "Tue, 5 Apr 2016 16:54:24 +1000")
Jookia <166291@gmail.com> skribis:
> On Mon, Apr 04, 2016 at 09:19:47PM -0700, Chris Marusich wrote:
>> ludo@gnu.org (Ludovic Courtès) writes:
>>
>> > ludo@gnu.org (Ludovic Courtès) skribis:
>> >
>> >> I’ve tested that with this patch changing colors under the “Style” tab
>> >> in Xfce does have an effect.
>> >>
>> >> I’ll commit it shortly if there are no objections.
>> >
>> > Pushed a slightly different version as
>> > ae05e366bea4517f1e428799f00f11997ccef661.
>>
>> This fixed the issue for me. Thanks!
>>
>> --
>> Chris
>
> I heavily disagree with this approach for two reasons:
>
> 1) It doesn't work with user theme installs.
Right, it’s mostly a hack to fix the immediate issue, which probably
covers many use cases since ‘xfce-desktop-service’ and
‘gnome-desktop-service’ install things globally.
> 2) I have a patch that fixes this problem completely.
> 3) The fix I provided has been duplicated upstream in GTK+.
>
> I suggest reverting this and applying my patch and read the full breakdown of
> the issue and solution here:
>
> https://lists.gnu.org/archive/html/guix-devel/2016-03/msg00492.html
Oh, I had overlooked this one, sorry about that!
Ricardo raised some concerns in that thread, namely that the patch
hard-codes a specific profile name as well. Did you have a chance to
look into it?
Thanks for the heads-up, and my apologies for overlooking it!
Ludo’.
next prev parent reply other threads:[~2016-04-05 8:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-02 21:46 bug#23200: XFCE: selecting a style has no effect Chris Marusich
2016-04-03 2:10 ` Jookia
2016-04-03 6:51 ` Ricardo Wurmus
2016-04-03 23:55 ` Chris Marusich
2016-04-04 20:26 ` Ludovic Courtès
2016-04-04 21:48 ` Ludovic Courtès
2016-04-05 4:19 ` Chris Marusich
2016-04-05 6:54 ` Jookia
2016-04-05 7:04 ` Chris Marusich
2016-04-05 8:11 ` Ludovic Courtès [this message]
2016-04-05 8:31 ` Jookia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bn5oxyp6.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=166291@gmail.com \
--cc=23200-done@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.