[PATCH] gnu: xfce4-taskmanager: Build with GTK+ 3 support.

[PATCH] gnu: xfce4-taskmanager: Build with GTK+ 3 support.

[Kei Yamashita]

[-- Attachment #1: Type: text/plain, Size: 112 bytes --]

This is a useful addition now that I know libwnck was stopping me from
building the GTK+ 3 version of this tool!

[-- Attachment #2: 0001-gnu-xfce4-taskmanager-Build-with-GTK-3-support.patch --]
[-- Type: application/octet-stream, Size: 1103 bytes --]

From 4769f77c8fafce5aa008817694ca161139bcf2e2 Mon Sep 17 00:00:00 2001
From: Kei Yamashita <kei@openmailbox.org>
Date: Mon, 25 Apr 2016 23:56:59 -0400
Subject: [PATCH] gnu: xfce4-taskmanager: Build with GTK+ 3 support.

* gnu/packages/xfce.scm (xfce4-taskmanager)[arguments]: New field.
---
 gnu/packages/xfce.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index c164c66..83d55c4 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -803,12 +803,14 @@ the desktop wallpaper.")
                (base32
                 "1jwywmkkkmz7406m1jq40w6apiav25cznafhigbgpjv6z5hv27if"))))
     (build-system gnu-build-system)
+    (arguments
+     '(#:configure-flags '("--enable-gtk3")))
     (native-inputs
      `(("intltool" ,intltool)
        ("pkg-config" ,pkg-config)))
     (inputs
      `(("libwnck" ,libwnck-2)
-       ("gtk+" ,gtk+-2)))
+       ("gtk+" ,gtk+)))
     (home-page "http://goodies.xfce.org/projects/applications/xfce4-taskmanager")
     (synopsis "Easy to use task manager")
     (description
-- 
2.7.4

Re: [PATCH] gnu: xfce4-taskmanager: Build with GTK+ 3 support.

[宋文武]

Kei Yamashita <kei@openmailbox.org> writes:

> This is a useful addition now that I know libwnck was stopping me from
> building the GTK+ 3 version of this tool!
Well, with gtk+-3, the libwnck-2 and gtk+-2  will not be
used (not in the closure), so I'd like leave only gtk+ in inputs,
but it seems gtk+-2 is required by the configure script even it's not
needed.

Maybe we should report it to upstream, but I think gtk+-2 version is
enough for us :-)

Thanks!

Re: [PATCH] gnu: xfce4-taskmanager: Build with GTK+ 3 support.

[Ludovic Courtès]

iyzsong@member.fsf.org (宋文武) skribis:

> Kei Yamashita <kei@openmailbox.org> writes:
>
>> This is a useful addition now that I know libwnck was stopping me from
>> building the GTK+ 3 version of this tool!
> Well, with gtk+-3, the libwnck-2 and gtk+-2  will not be
> used (not in the closure), so I'd like leave only gtk+ in inputs,
> but it seems gtk+-2 is required by the configure script even it's not
> needed.

To be sure, I think it would be best to add:

  #:disallowed-references ,(list gtk+2 libwnck-2)

with a comment explaining the bug.

Ludo’.