From: Ricardo Wurmus <rekado@elephly.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] guix: Add downloader for Mercurial repositories.
Date: Wed, 15 Jun 2016 17:10:16 +0200 [thread overview]
Message-ID: <87bn32xzc7.fsf@elephly.net> (raw)
In-Reply-To: <87d1niefu3.fsf@gnu.org>
Ludovic Courtès <ludo@gnu.org> writes:
> Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:
>
>> * guix/build/hg.scm: New file.
>> * guix/hg-download.scm: New file.
>> * Makefile.am (MODULES): Add them.
>
> [...]
>
>> + (gexp->derivation (or name "hg-checkout") build
>> + #:system system
>> + #:local-build? #t ;don't offload repo cloning
>> + #:hash-algo hash-algo
>> + #:hash hash
>> + #:recursive? #t
>> + #:modules '((guix build hg)
>> + (guix build utils))
>> + #:guile-for-build guile
>> + #:local-build? #t)))
>
> Apart from the duplicate #:local-build? that Efraim reported on IRC,
> this looks all good!
Thanks. I removed the second “#:local-build?” (someone™ should also
remove it from “git-download.scm” which served as a template) and pushed
to master.
~~ Ricardo
prev parent reply other threads:[~2016-06-15 15:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 8:41 [PATCH] guix: Add downloader for Mercurial repositories Ricardo Wurmus
2016-06-15 13:34 ` Ludovic Courtès
2016-06-15 15:10 ` Ricardo Wurmus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bn32xzc7.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.