From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 3/4] services: Add rngd-service.
Date: Tue, 05 Jul 2016 11:11:23 +0200
Message-ID: <87bn2czbyc.fsf@gnu.org>
References: <20160703014231.GA1178@jasmine>
	<20160703182510.21181-3-david@craven.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52140)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bKMOC-0004py-S1
	for guix-devel@gnu.org; Tue, 05 Jul 2016 05:11:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bKMO8-0003S4-E1
	for guix-devel@gnu.org; Tue, 05 Jul 2016 05:11:31 -0400
In-Reply-To: <20160703182510.21181-3-david@craven.ch> (David Craven's message
	of "Sun, 3 Jul 2016 20:25:09 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org

David Craven <david@craven.ch> skribis:

> * gnu/services/base.scm: New service.
> * doc/guix.texi: Add documentation.

Neat!  I adjusted the commit log and made minor changes:

> +(define-record-type* <rngd-configuration>
> +  rngd-configuration make-rngd-configuration
> +  rngd-configuration?
> +  (rng-tools rngd-configuration-rng-tools)
> +  (rng-device rngd-configuration-rngd-device))

I changed =E2=80=9Crng-device=E2=80=9D to =E2=80=9Cdevice=E2=80=9D here and=
 in similar places (=E2=80=9Crng=E2=80=9D
seemed redundant.)

> +(define* (rngd-service #:key
> +  (rng-tools rng-tools)
> +  (rng-device "/dev/hwrng"))

Reindented this.

Thanks!

Ludo=E2=80=99.