all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 3/4] services: Add rngd-service.
Date: Tue, 05 Jul 2016 11:11:23 +0200	[thread overview]
Message-ID: <87bn2czbyc.fsf@gnu.org> (raw)
In-Reply-To: <20160703182510.21181-3-david@craven.ch> (David Craven's message of "Sun, 3 Jul 2016 20:25:09 +0200")

David Craven <david@craven.ch> skribis:

> * gnu/services/base.scm: New service.
> * doc/guix.texi: Add documentation.

Neat!  I adjusted the commit log and made minor changes:

> +(define-record-type* <rngd-configuration>
> +  rngd-configuration make-rngd-configuration
> +  rngd-configuration?
> +  (rng-tools rngd-configuration-rng-tools)
> +  (rng-device rngd-configuration-rngd-device))

I changed “rng-device” to “device” here and in similar places (“rng”
seemed redundant.)

> +(define* (rngd-service #:key
> +  (rng-tools rng-tools)
> +  (rng-device "/dev/hwrng"))

Reindented this.

Thanks!

Ludo’.

  reply	other threads:[~2016-07-05  9:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-03  0:16 [PATCH] services: Add rngd service David Craven
2016-07-03  1:42 ` Leo Famulari
2016-07-03  2:05   ` [PATCH 1/3] gnu: Reorder imports alphabetically David Craven
2016-07-03 21:31     ` Leo Famulari
2016-07-03 21:50       ` David Craven
2016-07-03  2:21   ` [PATCH] services: Add rngd service David Craven
2016-07-03  2:26   ` [PATCH 2/3] gnu: Add rng-tools 5 David Craven
2016-07-03 21:31     ` Leo Famulari
2016-07-03  2:26   ` [PATCH 3/3] services: Add rngd-service David Craven
2016-07-03 18:25   ` [PATCH 3/4] " David Craven
2016-07-05  9:11     ` Ludovic Courtès [this message]
2016-07-03 18:25   ` [PATCH 4/4] build: Ignore texi2pdf temporary files David Craven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bn2czbyc.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=david@craven.ch \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.