Re: core-updates, next release, and all that

[ludo@gnu.org (Ludovic Courtès)]

Andreas Enge <andreas@enge.fr> skribis:

> On Sun, Jul 24, 2016 at 12:59:22PM -0400, Leo Famulari wrote:
>> So strange. Could the source code have been corrupted while unpacking?
>> Can anyone replicate this locally, so they can use --keep-failed?
>
> Yes, but I still cannot make anything of it.
>
> The build phase boils down to
>    cd /tmp/guix-build-lpsolve-5.5.2.0.drv-0/lp_solve_5.5/lpsolve55
>    bash ccc
> where the latter command eventually runs
>    gcc -s -c -I.. -I../shared -I../bfp -I../bfp/bfp_LUSOL -I../bfp/bfp_LUSOL/LUSOL -I../colamd -O3 $def $NOISNAN -DYY_NEVER_INTERACTIVE -DPARSER_LP -DINVERSE_ACTIVE=INVERSE_LUSOL -DRoleIsExternalInvEngine ../lp_MDO.c ../shared/commonlib.c ../shared/mmio.c ../shared/myblas.c ../ini.c ../fortify.c ../colamd/colamd.c ../lp_rlp.c ../lp_crash.c ../bfp/bfp_LUSOL/lp_LUSOL.c ../bfp/bfp_LUSOL/LUSOL/lusol.c ../lp_Hash.c ../lp_lib.c ../lp_wlp.c ../lp_matrix.c ../lp_mipbb.c ../lp_MPS.c ../lp_params.c ../lp_presolve.c ../lp_price.c ../lp_pricePSE.c ../lp_report.c ../lp_scale.c ../lp_simplex.c ../lp_SOS.c ../lp_utils.c ../yacc_read.c
>
> When I source the environment variables of the build, then gcc-4.9 is used,
> and the error message is printed. When I just install gcc-toolchain@5, it
> passes. But I do not think that the compiler version makes a difference.
>
> The offending lines are
> #ifndef FALSE
>   #define FALSE        0
>   #define TRUE         1
> #endif
> which looks perfectly good. When I remove them, then the compiler complains
> that FALSE is not defined.

Fixed in commit 5dbfbef7292a43029b17e89d682d9e24703d5cd2.

(The problem was a wrong ‘isnan’ feature test, leading to -DNOISNAN,
leading to “#define isnan(x) FALSE”, so the ‘isnan’ declaration in
<math.h> was turned into “extern int FALSE __attribute__
((__nothrow__ , __leaf__)) __attribute__ ((__const__));”…)

Ludo’.