From mboxrd@z Thu Jan 1 00:00:00 1970 From: ng0 Subject: Re: [PATCH] Add python-pythondialog Date: Thu, 28 Jul 2016 09:34:44 +0000 Message-ID: <87bn1ihzrf.fsf@we.make.ritual.n0.is> References: <87lh1hcp18.fsf@we.make.ritual.n0.is> <20160704180530.GB13592@jasmine> <871t39jlzw.fsf@we.make.ritual.n0.is> <871t2fgvlk.fsf@we.make.ritual.n0.is> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52748) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bShiQ-0005eY-Kv for guix-devel@gnu.org; Thu, 28 Jul 2016 05:35:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bShiO-0008J7-9J for guix-devel@gnu.org; Thu, 28 Jul 2016 05:34:53 -0400 Received: from mithlond.libertad.in-berlin.de ([2001:67c:1400:2490::1]:55724 helo=beleriand.n0.is) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bShiN-0008IR-VA for guix-devel@gnu.org; Thu, 28 Jul 2016 05:34:52 -0400 Received: by beleriand.n0.is (OpenSMTPD) with ESMTPSA id 735876a0 TLS version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO for ; Thu, 28 Jul 2016 09:34:49 +0000 (UTC) In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel Hi, thanks for working on this. Vincent Legoll writes: >>> If we inherit, we should let python2- inherit from python3. >>> >>> I was not sure about the right way to process with this, so it >>> ended up in 2 packages. >> >> There has been no update on this for 3 weeks. >> Could someone look into this and reply? > > Is that what you want ? > This is still untested though, but I'll try the 2 packages I don't understand. Is this completely untested or have you tested this before sending the patch? > -- > Vincent Legoll > From 8b6becfd95235e1559cdb4a3760c5928d707e6cf Mon Sep 17 00:00:00 2001 > From: Vincent Legoll > Date: Wed, 27 Jul 2016 14:28:06 +0200 > Subject: [PATCH] Add python-pythondialog > > Signed-off-by: Vincent Legoll > --- > gnu/packages/python.scm | 21 ++++++++++++++++----- > 1 file changed, 16 insertions(+), 5 deletions(-) > > diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm > index 80ff81f..533d731 100644 > --- a/gnu/packages/python.scm > +++ b/gnu/packages/python.scm > @@ -6654,17 +6654,17 @@ facilities for defining, registering and looking up components.") > (define-public python2-zope-component > (package-with-python2 python-zope-component)) > > -(define-public python2-pythondialog > +(define-public python-pythondialog > (package > - (name "python2-pythondialog") > + (name "python-pythondialog") > (version "3.4.0") > (source > (origin > (method url-fetch) > - (uri (pypi-uri "python2-pythondialog" version)) > + (uri (pypi-uri "pythondialog" version)) > (sha256 > (base32 > - "0d8k7lxk50imdyx85lv8j98i4c93a71iwpapnl1506rpkbm9qvd9")))) > + "1728ghsran47jczn9bhlnkvk5bvqmmbihabgif5h705b84r1272c")))) > (build-system python-build-system) > (arguments > `(#:phases > @@ -6678,7 +6678,6 @@ facilities for defining, registering and looking up components.") > (("os.getenv\\(\"PATH\", \":/bin:/usr/bin\"\\)") > (string-append "os.getenv(\"PATH\") + \":" dialog "/bin\""))) > #t)))) > - #:python ,python-2 > #:tests? #f)) ; no test suite > (propagated-inputs > `(("dialog" ,dialog))) > @@ -6689,6 +6688,18 @@ provide an easy to use, pythonic and comprehensive Python interface to dialog. > This allows one to make simple text-mode user interfaces on Unix-like systems") > (license lgpl2.1))) > > +(define-public python2-pythondialog > + (package-with-python2 > + (package (inherit python-pythondialog) > + (name "python2-pythondialog") > + (source > + (origin > + (method url-fetch) > + (uri (pypi-uri "python2-pythondialog" version)) > + (sha256 > + (base32 > + "0d8k7lxk50imdyx85lv8j98i4c93a71iwpapnl1506rpkbm9qvd9")))))) > + > (define-public python-pyrfc3339 > (package > (name "python-pyrfc3339") > -- > 1.9.1 > -- ♥Ⓐ ng0 Current Keys: https://we.make.ritual.n0.is/ng0.txt For non-prism friendly talk find me on http://www.psyced.org