Hi Ricardo,

Thanks for the review too. The changes looks good to me, excepts that it
seems 'find-files' will find all files with name matching the regex
recursively, but `scandir' will only list the files on the 1st
level. Should we change 'find-files so that it supports the concept of
depth as well?

Also, I realize there is a typo in my original patch. It should be
'under' instead of 'under under' in the comment.

Here is the changes I make:

1 file changed, 8 insertions(+), 3 deletions(-)
gnu/packages/java.scm | 11 ++++++++---

modified   gnu/packages/java.scm
@@ -172,6 +172,8 @@ is implemented.")
       (arguments
        `(#:modules ((guix build ant-build-system)
                     (guix build utils)
+                    (ice-9 ftw)
+                    (ice-9 regex)
                     (srfi srfi-1)
                     (srfi srfi-26))
          #:test-target "test"
@@ -223,7 +225,10 @@ is implemented.")
                  (copy-recursively "target/javadoc/"
                                    (string-append doc-dir "javadoc/"))
                  (for-each (cut install-file <> doc-dir)
-                           (find-files "." ".*\\.(html|markdown|md|txt)"))
+                           (filter (cut string-match
+                                     ".*\\.(html|markdown|md|txt)"
+                                     <>)
+                                   (scandir "./")))
                  #t))))))
       ;; The native-inputs below are needed to run the tests.
       (native-inputs
@@ -269,8 +274,8 @@ system and reactive Agent system that ensure clean, correct, multithreaded
 designs.")
       ;; Clojure is licensed under EPL1.0
       ;; ASM bytecode manipulation library is licensed under BSD-3
-      ;; Guava Murmur3 hash implementation is licensed under under APL2.0
-      ;; src/clj/repl.clj is licensed under under CPL1.0
+      ;; Guava Murmur3 hash implementation is licensed under APL2.0
+      ;; src/clj/repl.clj is licensed under CPL1.0
       ;;
       ;; See readme.html or readme.txt for details.
       (license (list license:epl1.0


Here is the whole patch: