From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Use a directory owned by ntpd user for drift file.
Date: Wed, 07 Sep 2016 22:36:05 +0200
Message-ID: <87bmzzla6i.fsf@gnu.org>
References: <1473277956-22799-1-git-send-email-jmd@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41783)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bhjZu-0002dy-2s
	for guix-devel@gnu.org; Wed, 07 Sep 2016 16:36:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bhjZp-0002xT-6D
	for guix-devel@gnu.org; Wed, 07 Sep 2016 16:36:13 -0400
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47704)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1bhjZp-0002wx-3E
	for guix-devel@gnu.org; Wed, 07 Sep 2016 16:36:09 -0400
In-Reply-To: <1473277956-22799-1-git-send-email-jmd@gnu.org> (John
	Darrington's message of "Wed, 7 Sep 2016 21:52:36 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: John Darrington <jmd@gnu.org>
Cc: guix-devel@gnu.org

John Darrington <jmd@gnu.org> skribis:

> Fixes bug #24366

Rather:

  Fixes <http://bugs.gnu.org/24366>.

(See =E2=80=98git log=E2=80=99 for examples.)

>
>
>
> * gnu/services/networking.scm (ntp-shepherd-service): Create new
> directory at startup.

Please mention the new variables and changes.

> +(define (ntp-service-activation config)
> +  "Return the activation gexp for config"
                                     ^^^^^^^
Capitalize the variable name and add a period.

> +  #~(begin
> +      (use-modules (guix build utils))

Please wrap the gexp in:

  (with-imported-modules '((guix build utils))
    #~(=E2=80=A6))

> +      (let ((directory "/var/run/ntpd"))
> +          (mkdir-p directory)
            ^^
Indentation.

OK with these changes.

Thanks for fixing this bug!

Ludo=E2=80=99.