From: ng0 <ngillmann@runbox.com>
To: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: femtolisp: Remove support for mips and armhf.
Date: Tue, 27 Sep 2016 08:13:53 +0000 [thread overview]
Message-ID: <87bmz9pxoe.fsf@we.make.ritual.n0.is> (raw)
In-Reply-To: <87mvivj68i.fsf@gnu.org>
[-- Attachment #1.1: Type: text/plain, Size: 2143 bytes --]
Ludovic Courtès <ludo@gnu.org> writes:
> ng0 <ngillmann@runbox.com> skribis:
>
>> Ludovic Courtès <ludo@gnu.org> writes:
>>
>>> Andreas Enge <andreas@enge.fr> skribis:
>>>
>>>> femtolisp fails on mips and arm:
>>>> http://hydra.gnu.org:3000/build/1472987/nixlog/2/tail-reload
>>>> with the message
>>>> In file included from llt/llt.h:6:0,
>>>> from string.c:16:
>>>> llt/utils.h:27:4: error: #error "unknown architecture"
>>>> # error "unknown architecture"
>>>>
>>>> Should it be disabled there?
>>>
>>> Definitely. It would be worth checking in that file the set of
>>> supported architectures, and putting them in ‘supported-platforms’.
>>
>> I'm not exactly sure what's supported, I found win32, osx, freebsd,
>> openbsd, and that's it.
>
> Sorry, I really meant supported architectures, which is what utils.h
> seems to be about (although I don’t have the source here to check).
> Could you check the #ifdefs in there?
#if defined( __amd64__ ) || defined( _M_AMD64 )
# define ARCH_X86_64
# define __CPU__ 686
#elif defined( _M_IX86 )//msvs, intel, digital mars, watcom
# if ! defined( __386__ )
# error "unsupported target: 16-bit x86"
# endif
# define ARCH_X86
# define __CPU__ ( _M_IX86 + 86 )
#elif defined( __i686__ )//gnu c
# define ARCH_X86
# define __CPU__ 686
#elif defined( __i586__ )//gnu c
# define ARCH_X86
# define __CPU__ 586
#elif defined( __i486__ )//gnu c
# define ARCH_X86
# define __CPU__ 486
#elif defined( __i386__ )//gnu c
# define ARCH_X86
# define __CPU__ 386
#else
# error "unknown architecture"
#endif
>> + ;; armhf and mips64el fail to build, it has been reported upstream:
>> + ;; https://github.com/JeffBezanson/femtolisp/issues/25
>> + (supported-systems
>> + (and
>> + (delete "armhf-linux" %supported-systems)
>> + (delete "mips64el-linux" %supported-systems)
>> + #t))
>
> ‘supported-systems’ must be a list of strings, so:
>
> (fold delete %supported-systems
> '("armhf-linux" "mips64el-linux"))
>
> Thanks,
> Ludo’.
>
[-- Attachment #1.2: 0001-gnu-femtolisp-Remove-support-for-mips-and-armhf.patch --]
[-- Type: text/x-patch, Size: 1812 bytes --]
From 32c4d64ada9ab2573a00385b15b2b0a03a6fa44f Mon Sep 17 00:00:00 2001
From: ng0 <ngillmann@runbox.com>
Date: Thu, 22 Sep 2016 09:08:03 +0000
Subject: [PATCH] gnu: femtolisp: Remove support for mips and armhf.
* gnu/packages/lisp.scm (femtolisp)[supported-systems]: New field,
remove support for mips64el and armhf.
---
gnu/packages/lisp.scm | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm
index d1180a7..439433a 100644
--- a/gnu/packages/lisp.scm
+++ b/gnu/packages/lisp.scm
@@ -3,7 +3,7 @@
;;; Copyright © 2015 Taylan Ulrich Bayırlı/Kammer <taylanbayirli@gmail.com>
;;; Copyright © 2015 Mark H Weaver <mhw@netris.org>
;;; Copyright © 2016 Federico Beffa <beffa@fbengineering.ch>
-;;; Copyright © 2016 ng0 <ng0@we.make.ritual.n0.is>
+;;; Copyright © 2016 ng0 <ngillmann@runbox.com>
;;; Copyright © 2016 Andy Patterson <ajpatter@uwaterloo.ca>
;;;
;;; This file is part of GNU Guix.
@@ -44,7 +44,8 @@
#:use-module (gnu packages ed)
#:use-module (gnu packages m4)
#:use-module (gnu packages version-control)
- #:use-module (ice-9 match))
+ #:use-module (ice-9 match)
+ #:use-module (srfi srfi-1))
(define-public gcl
(package
@@ -501,6 +502,11 @@ the InterLisp Standard.")
(sha256
(base32
"04rnwllxnl86zw8c6pwxznn49bvkvh0f1lfliy085vjzvlq3rgja"))))
+ ;; See "utils.h" for supported systems. Upstream bug:
+ ;; https://github.com/JeffBezanson/femtolisp/issues/25
+ (supported-systems
+ (fold delete %supported-systems
+ '("armhf-linux" "mips64el-linux")))
(build-system gnu-build-system)
(arguments
`(#:make-flags '("CC=gcc" "release")
--
2.10.0
[-- Attachment #1.3: Type: text/plain, Size: 26 bytes --]
--
ng0
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 800 bytes --]
next prev parent reply other threads:[~2016-09-27 8:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 19:04 [PATCH 1/2] gnu: Add femtolisp ng0
2016-09-13 19:04 ` [PATCH 2/2] gnu: lispf4: Remove unused inputs key ng0
2016-09-13 19:30 ` [PATCH 1/2] gnu: Add femtolisp Ricardo Wurmus
2016-09-13 19:45 ` ng0
2016-09-13 20:32 ` ng0
2016-09-14 9:00 ` Ricardo Wurmus
2016-09-14 9:31 ` ng0
2016-09-14 9:48 ` ng0
2016-09-14 10:03 ` Ricardo Wurmus
2016-09-14 10:15 ` ng0
2016-09-14 11:05 ` Ricardo Wurmus
2016-09-14 11:17 ` ng0
2016-09-14 12:03 ` ng0
2016-09-18 10:02 ` Andreas Enge
2016-09-20 6:14 ` Ludovic Courtès
2016-09-21 10:37 ` ng0
2016-09-21 15:33 ` Ludovic Courtès
2016-09-21 19:30 ` Ricardo Wurmus
2016-09-22 9:11 ` [PATCH] gnu: femtolisp: Remove support for mips and armhf ng0
2016-09-26 10:38 ` Ludovic Courtès
2016-09-27 8:13 ` ng0 [this message]
2016-09-27 16:30 ` Leo Famulari
2016-09-18 12:20 ` [PATCH 1/2] gnu: Add femtolisp ng0
2016-09-18 12:25 ` ng0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bmz9pxoe.fsf@we.make.ritual.n0.is \
--to=ngillmann@runbox.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.