From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <rekado@elephly.net>
Subject: Re: [PATCH 2/2] gnu: Add emacs-org-trello.
Date: Tue, 25 Oct 2016 23:26:36 +0200
Message-ID: <87bmy8glwz.fsf@elephly.net>
References: <87oa2887b1.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51807)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1bz9FT-0007Bj-Eb
	for guix-devel@gnu.org; Tue, 25 Oct 2016 17:27:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rekado@elephly.net>) id 1bz9FP-0000an-B4
	for guix-devel@gnu.org; Tue, 25 Oct 2016 17:27:07 -0400
In-reply-to: <87oa2887b1.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Roel Janssen <roel@gnu.org>
Cc: guix-devel@gnu.org


Hi Roel,

funny, this has also been on my pile of unsubmitted, bit-rotting patches
(because I must use Trello at work and I much rather use org-mode).  I
remember that this wasn’t straight-forward to package and required a lot
more (build-time) inputs.

The cask file says:

(development
 (depends-on "dash-functional")
 (depends-on "dash")
 (depends-on "ert-runner")
 (depends-on "undercover")
 (depends-on "ert")
 (depends-on "ert-expectations")
 (depends-on "el-mock")
 (depends-on "helm"))

Should these be added?

> * gnu/packages/emacs.scm (emacs-org-trello): New variable.
> ---
>  gnu/packages/emacs.scm | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 69fd10f..964ba59 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -2086,6 +2086,32 @@ number.")
>  @code{org-mode} to be rendered as UTF-8 characters.")
>      (license license:gpl3+)))
>  
> +(define-public emacs-org-trello
> +  (package
> +    (name "emacs-org-trello")
> +    (version "0.7.9")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "https://github.com/org-trello/org-trello/archive/"
> +                    version ".tar.gz"))
> +              (file-name (string-append name "-" version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "074dka8g673bj1ck5vavbjaij5jyniygdlw51mdds005wd2br9wf"))))
> +    (build-system emacs-build-system)
> +    (propagated-inputs
> +     `(("emacs-deferred" ,emacs-deferred)
> +       ("emacs-request" ,emacs-request)
> +       ("emacs-dash" ,emacs-dash)
> +       ("emacs-s" ,emacs-s)))
> +    (home-page "https://org-trello.github.io")
> +    (synopsis "Emacs minor mode for interacting with Trello")
> +    (description "This package provides an emacs minor mode to extend

Please capitalize “Emacs”.

> +@code{org-mode} with Trello abilities.  Trello is an online project
> +organizer.")
> +    (license license:gpl3+)))
> +
>  (define-public emacs-zenburn-theme
>    (package
>      (name "emacs-zenburn-theme")

Other than that it looks good!

Thanks!

~~ Ricardo