From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Subject: Re: [PATCH 15/16] gnu: python-ipython: Update to 4.0.0.
Date: Fri, 4 Nov 2016 18:10:23 +0100
Message-ID: <87bmxv9nnk.fsf@mdc-berlin.de>
References: <20161101122046.751-1-ricardo.wurmus@mdc-berlin.de>
	<20161101122046.751-16-ricardo.wurmus@mdc-berlin.de>
	<87y413njwr.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49088)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1c2i0j-0007D9-2p
	for guix-devel@gnu.org; Fri, 04 Nov 2016 13:10:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1c2i0f-0002SJ-UM
	for guix-devel@gnu.org; Fri, 04 Nov 2016 13:10:37 -0400
In-Reply-To: <87y413njwr.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Roel Janssen <roel@gnu.org>
Cc: guix-devel@gnu.org


Roel Janssen <roel@gnu.org> writes:

> Ricardo Wurmus writes:
>
>> * gnu/packages/python.scm (python-ipython): Update to 4.0.0.
>>   [inputs]: Keep only "readline" and "which"; move the remaining input=
s
>>   to propagated-inputs, except for "python-requests" and "python-nose"
>>   which are moved to native-inputs.
>>   [propagated-inputs]: Add python-pexpect, python-pickleshare,
>>   python-simplegeneric, python-traitlets, python-ipykernel.
>>   [native-inputs]: Add "python-testpath".
>>   [arguments]: Enable building of HTML documentation.

I noticed that I also needed to delete the patch and report it here.
Also fixed the indentation.

>> +    (inputs
>> +     `(("readline" ,readline)
>> +       ("which" ,which)))
>
> I think it really is necessary to propagate these, isn't it?

Neither of these need propagation.  =E2=80=9Creadline=E2=80=9D is checked=
 for by
setup.py, and for =E2=80=9Cwhich=E2=80=9D we have a build phase to embed =
the reference
to the =E2=80=9Cwhich=E2=80=9D executable.

>>      (native-inputs
>>       `(("pkg-config" ,pkg-config)
>> +       ("python-requests" ,python-requests) ;; for tests
>> +       ("python-testpath" ,python-testpath)
>> +       ("python-nose" ,python-nose)
>>         ("python-sphinx" ,python-sphinx)
>>         ("texlive" ,texlive)
>>         ("texinfo" ,texinfo)
>> @@ -4674,13 +4678,13 @@ tools for mocking system commands and recordin=
g calls to those.")
>>                     (examples (string-append doc "/examples")))
>>                (setenv "LANG" "en_US.utf8")
>>                (with-directory-excursion "docs"
>> -                ;; FIXME: html and pdf fail to build
>> -                ;; (system* "make" "html")
>> -                ;; (system* "make" "pdf" "PAPER=3Da4")
>> +                ;; FIXME: pdf fails to build
>> +                ;;(system* "make" "pdf" "PAPER=3Da4")
>> +                (system* "make" "html")
>
> The last line isn't absolutely necessary to, but I it doesn't really
> matter and I see why you'd want to not have a space there.
> Nevertheless, you could shorten the patch by two lines if you feel like
> doing so.. :)

Are you saying that =E2=80=9Cmake html=E2=80=9D isn=E2=80=99t needed to b=
uild the html docs?  I
think it is.

~~ Ricardo