Re: [PATCH 4/7] gnu: Add kjs.

[Marius Bakke <mbakke@fastmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2274 bytes --]

Hartmut Goebel <h.goebel@crazy-compilers.com> writes:

> * gnu/packages/kde-frameworks.scm (kjs): New variable.
> ---
>  gnu/packages/kde-frameworks.scm | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
>
> diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
> index 07c6716..928b7ec 100644
> --- a/gnu/packages/kde-frameworks.scm
> +++ b/gnu/packages/kde-frameworks.scm
> @@ -43,6 +43,7 @@
>    #:use-module (gnu packages gnupg)
>    #:use-module (gnu packages image)
>    #:use-module (gnu packages linux)
> +  #:use-module (gnu packages pcre)
>    #:use-module (gnu packages perl)
>    #:use-module (gnu packages pkg-config)
>    #:use-module (gnu packages polkit)
> @@ -2994,3 +2995,34 @@ technology and using KJS for JavaScript support.")
>      ;; a variety of licenses
>      (license (list license:gpl2 license:lgpl2.0 license:lgpl2.1+ license:gpl3+
>                     license:expat license:bsd-2 license:bsd-3))))
> +
> +(define-public kjs
> +  (package
> +    (name "kjs")
> +    (version "5.27.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "mirror://kde/stable/frameworks/"
> +             (version-major+minor version) "/portingAids/"
> +             name "-" version ".tar.xz"))
> +       (sha256
> +        (base32 "18x4az3v4pbg77sxhmrdrfwrc9d9fw7l40m6p18k1khxn86hsp9j"))))
> +    (build-system cmake-build-system)
> +    (native-inputs
> +     `(("extra-cmake-modules" ,extra-cmake-modules)
> +       ("kdoctools" ,kdoctools)
> +       ("perl" ,perl)))
> +    (inputs
> +     `(("pcre" ,pcre)
> +       ("qtbase" ,qtbase)))
> +    (home-page "https://community.kde.org/Frameworks")
> +    (synopsis "KDE Frameworks 5 support for Javascript scripting in Qt
> +applications")
> +    (description "Add-on library to Qt which adds JavaScript scripting
> +support.")
> +    ;; a variety of licenses
> +    (license (list license:lgpl2.0+ license:lgpl2.1+
> +                   license:bsd-2 license:bsd-3
> +                   license:non-copyleft))))

What is non-copyleft here? Note that "non-copyleft" is a procedure and
can take a file:// style URI (or http etc) to the component in question,
along with an optional comment.

Otherwise LGTM.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 454 bytes --]