From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 2/2] system: Add btrfs file system support. Date: Sat, 03 Dec 2016 16:18:43 +0100 Message-ID: <87bmwtavn0.fsf@gnu.org> References: <20161130183635.6513-1-david@craven.ch> <20161130183635.6513-2-david@craven.ch> <87zikfsbk3.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34456) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cDC5R-0007tq-1p for guix-devel@gnu.org; Sat, 03 Dec 2016 10:18:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cDC5N-0000Uv-SI for guix-devel@gnu.org; Sat, 03 Dec 2016 10:18:49 -0500 In-Reply-To: (David Craven's message of "Fri, 2 Dec 2016 11:50:08 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: David Craven Cc: guix-devel David Craven skribis: > Then there is the label and uuid detection logic for every file-system > that needs to be implemented. I'm wondering if it can be refactored, a > quick late night and untested implementation for btrfs suggests that > there is a lot of code repetition involved, I guess the same will be > true for vfat. I'll have to check if there are any tests for this > anywhere or write some before I mess with this "core piece" of guix. This is covered by tests like =E2=80=9Cbasic=E2=80=9D and other lightweight= tests: they boot the system, so they get to exercise the file system label/UUID lookup code (if the root partition is specified by a label/UUID at least). > Ludo: Is there any way we can speed up the installer system tests? :) Most of the time is spent in building the latest Guix and running =E2=80=98= guix system init=E2=80=99. I don=E2=80=99t think this can be sped up. The QEMU images involved are copied around, and maybe that part can be slightly optimized. I did that in 130079ae27b47228516dc2934bcdecca5dbedf12. Ludo=E2=80=99.