From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Huang\, Ying" Subject: Re: [PATCH -v2] Fix gtk-im-modules for Gtk+3 Date: Sun, 05 Feb 2017 07:42:38 +0800 Message-ID: <87bmuhldzl.fsf@163.com> References: <20170130030649.1716-1-huang_ying_caritas@163.com> <20170204182805.099e8ba8@scratchpost.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41706) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ca9yl-0003Wi-DR for guix-devel@gnu.org; Sat, 04 Feb 2017 18:42:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ca9yg-0004Ou-I1 for guix-devel@gnu.org; Sat, 04 Feb 2017 18:42:51 -0500 Received: from m12-18.163.com ([220.181.12.18]:59669) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ca9yf-0004IV-Me for guix-devel@gnu.org; Sat, 04 Feb 2017 18:42:46 -0500 In-Reply-To: <20170204182805.099e8ba8@scratchpost.org> (Danny Milosavljevic's message of "Sat, 4 Feb 2017 18:28:05 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Danny Milosavljevic Cc: guix-devel@gnu.org Hi, Danny, Thanks for comments! Danny Milosavljevic writes: > Hi, > > On Mon, 30 Jan 2017 11:06:49 +0800 > huang_ying_caritas@163.com wrote: > >> -(define* (manifest-lookup-package manifest name #:optional version) >> +(define* (manifest-lookup-package manifest name #:optional version output) >> "Return as a monadic value the first package or store path referenced by >> MANIFEST that is named NAME and optionally has the given VERSION prefix, or #f >> if not found." > > Please update the docstring too. Sure. >> + (if output >> + (string-suffix? output version*) >> #t)))) > > Should that include the separator between the parts? Otherwise it > could maybe have false positives... OK. Best Regards, Huang, Ying