all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: Guix-devel <guix-devel@gnu.org>, 25598@debbugs.gnu.org
Subject: bug#25598: [PATCH] More reproducibility fixes for R.
Date: Fri, 10 Feb 2017 13:38:07 +0100	[thread overview]
Message-ID: <87bmuafcgg.fsf__3630.64160706035$1486730356$gmane$org@gnu.org> (raw)
In-Reply-To: <idj4m03whdy.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's message of "Thu, 9 Feb 2017 15:47:21 +0100")

Hi!

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:

> attached are more reproducibility fixes for R.  Unfortunately, it seems
> that files of type “rdb”, “rdx”, and “rds” are still not reproducible.
> This leaves us with the following files in R that are currently not
> reproducible:

Could it be that --built-timestamp is not honored for R modules within R?
Do the Debian patches mentioned in #25598 help?

> From e8cd2114b824ab6fed671c2214956ee22deeaedf Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Thu, 9 Feb 2017 14:34:57 +0100
> Subject: [PATCH 1/2] gnu: r: Fix syntax for INSTALL_OPTS.
>
> This is a follow-up to commit 4621acfd8272fa93d0530faa5f015b26a194b587.
>
> * gnu/packages/statistics.scm (r)[arguments]: Ensure that
> "--built-timestamp" appears on the same line as the other INSTALL_OPTS.

So the previous attempt had no effect, right?

LGTM.

> From 95b939f662a29b3cc6973a2fba286f32faf010c1 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Thu, 9 Feb 2017 15:40:02 +0100
> Subject: [PATCH 2/2] gnu: r: Fix more reproducibility problems.
>
> * gnu/packages/statistics.scm (r)[arguments]: Patch locations in the
> build system that need special treatment for reproducibility.

LGTM, thanks!

Ludo’.

  parent reply	other threads:[~2017-02-10 12:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-01  9:55 bug#25598: R packages are not bit-reproducible Ludovic Courtès
2017-02-01 11:08 ` Ricardo Wurmus
2017-02-01 13:00   ` Ludovic Courtès
2017-02-09 14:47 ` [PATCH] More reproducibility fixes for R Ricardo Wurmus
2017-02-10 12:38   ` Ludovic Courtès
2017-03-08 11:53     ` bug#25598: " Ricardo Wurmus
2017-02-10 12:38   ` Ludovic Courtès [this message]
2017-03-08 17:56   ` Ricardo Wurmus
2017-03-08 17:56   ` bug#25598: " Ricardo Wurmus
2017-03-16  7:54 ` bug#25598: [PATCH] gnu: r: Fix remaining reproducibility problems Ricardo Wurmus
2017-03-16  9:00   ` Ludovic Courtès
2017-03-17  9:17     ` Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='87bmuafcgg.fsf__3630.64160706035$1486730356$gmane$org@gnu.org' \
    --to=ludo@gnu.org \
    --cc=25598@debbugs.gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=ricardo.wurmus@mdc-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.