From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44288) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu1nG-00074w-H0 for guix-patches@gnu.org; Fri, 31 Mar 2017 15:01:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cu1nD-00024h-Fd for guix-patches@gnu.org; Fri, 31 Mar 2017 15:01:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:56565) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cu1nD-00024Z-AO for guix-patches@gnu.org; Fri, 31 Mar 2017 15:01:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cu1nC-00015Z-Bo for guix-patches@gnu.org; Fri, 31 Mar 2017 15:01:03 -0400 Subject: bug#26294: [PATCH] gnu: rocksdb: Disable tests on 32-bit systems. Resent-Message-ID: From: Kei Kebreau References: <20170329094220.5694-1-mbakke@fastmail.com> Date: Fri, 31 Mar 2017 15:00:33 -0400 In-Reply-To: <20170329094220.5694-1-mbakke@fastmail.com> (Marius Bakke's message of "Wed, 29 Mar 2017 11:42:20 +0200") Message-ID: <87bmsh5l0u.fsf@openmailbox.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Marius Bakke Cc: 26294@debbugs.gnu.org --=-=-= Content-Type: text/plain Marius Bakke writes: > * gnu/packages/databases.scm (rocksdb)[arguments]: Make #:tests? conditional. > Delete unnecessary 'build' phase. > --- > gnu/packages/databases.scm | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm > index b87e8a210..e73635910 100644 > --- a/gnu/packages/databases.scm > +++ b/gnu/packages/databases.scm > @@ -533,12 +533,20 @@ types are supported, as is encryption.") > #t)))) > (build-system gnu-build-system) > (arguments > - '(#:make-flags (list "CC=gcc" > + `(#:make-flags (list "CC=gcc" > ;; Make the resulting library position-independent so the > ;; static version can be included in shared objects. > "EXTRA_CXXFLAGS=-fPIC" > (string-append "INSTALL_PATH=" > (assoc-ref %outputs "out"))) > + ;; Many tests fail on 32-bit platforms. There are multiple reports about > + ;; this upstream, but it's not going to be supported any time soon. > + #:tests? (let ((system ,(or (%current-target-system) > + (%current-system))) > + (supported-systems '("x86_64-linux" "aarch64-linux"))) > + (if (member system supported-systems) > + #t > + #f)) > #:phases > (modify-phases %standard-phases > (add-after 'unpack 'patch-Makefile > @@ -548,6 +556,8 @@ types are supported, as is encryption.") > (("#!/bin/sh") (string-append "#!" (which "sh")))) > #t)) > (delete 'configure) > + ;; The default target is only needed for tests and built on demand. > + (delete 'build) > (add-before 'check 'disable-failing-tests > (lambda _ > (substitute* "Makefile" I'm unable to test your claim about 32-bit tests (I'm getting HTTP error code 504 when attempt to access info on hydra.gnu.org), but the package builds and lints fine for me on x86_64. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAljep1EACgkQ5qXuPBlG eg03BxAAhuuzdC9lPrRkMp7FNwYvW5RuPn5/unmFYs26fRajxbWZICy+SsN97zZe h8waQWllWeFY/3m1wTYy+qTG+75VUgjlGkhCRajTMNRq3F1fhxvmwMF802z1+Xtq Q/dTawBXHzdYllJlVoKMfGn5xJ5UrpeuN3Yvn2KUDNBuRQjacmMNDbyv/rTTbQa0 ovbziB00/i7IR9y+tMMHL1aG06YSAAg42QGcaTqUYGMh0483m1bbZ2tmxVtJFRPK 9lVMTqQDzmEANau19Zk7/AU1puofMYqCxf+FDdalMHZ4yH2/8/+iHl8hCNx9PvF7 q73IbNJoWVedWJCGVCxZZrjh3hGqUQ5vnpW1LoyMdI0etOUwoE30nOX4/Cy05VQ3 +b8bvydQJL6WTraK4NqrDTn0DZdxT52SiYuiu4XdeCC06vW+zBJrS+MNrKr8RK4T BDWxR2NKEajLLaWVkebUA9i9kF4AFFdgWFYYwlEskLNkbDY0luFHYBwLWRtLwPeU eM6oVsK5yR81VmhMT92O+wG4OVc5TOwcNZSVA19KhZiM5hrd0Fm/gGHoFfI7Ayd3 cZRHw7ze3mOeexybBU68kiNfcthC3Et2v70CvjaHsKmWNwpVTBkwnv4eRBo1f08w L0ejoOihJz0N/vLSKK+9WyBk7teJrZvMYajrVLBkrAB4ioXoc2g= =5prQ -----END PGP SIGNATURE----- --=-=-=--