From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52137)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d6fdJ-0001cl-Qv
	for guix-patches@gnu.org; Fri, 05 May 2017 11:59:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d6fdG-0004F2-Em
	for guix-patches@gnu.org; Fri, 05 May 2017 11:59:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:58375)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1d6fdG-0004Ey-Bj
	for guix-patches@gnu.org; Fri, 05 May 2017 11:59:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d6fdG-0001Xz-5A
	for guix-patches@gnu.org; Fri, 05 May 2017 11:59:02 -0400
Subject: bug#26784: Add linuxdcpp
Resent-Message-ID: <handler.26784.B26784.14939998975893@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <d522471e.AEEAKUJzKeIAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZDJEO@mailjet.com>
Date: Fri, 05 May 2017 17:58:03 +0200
In-Reply-To: <d522471e.AEEAKUJzKeIAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZDJEO@mailjet.com>
	(Arun Isaac's message of "Fri, 05 May 2017 20:19:23 +0530")
Message-ID: <87bmr79tys.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 26784@debbugs.gnu.org

Hi Arun,

Arun Isaac <arunisaac@systemreboot.net> skribis:

> Please find attached a patch adding linuxdcpp to Guix.
>
> From b3f3bd48c0d8216c1c9276c07a0c5b3117b2f3d2 Mon Sep 17 00:00:00 2001
> From: Arun Isaac <arunisaac@systemreboot.net>
> Date: Fri, 5 May 2017 19:40:31 +0530
> Subject: [PATCH] gnu: Add linuxdcpp.
>
> * gnu/packages/direct-connect.scm (linuxdcpp): New variable.

[...]

> +         (replace 'build
> +           (lambda* (#:key inputs outputs #:allow-other-keys)
> +             (let ((out (assoc-ref outputs "out")))
> +               (mkdir-p out)
> +               (zero? (system* "scons" (string-append "PREFIX=3D" out)))=
)))

If it makes sense you could add:

  "-j" (number->string (parallel-job-count))

Otherwise LGTM.

Thanks!

Ludo=E2=80=99.