From: ludo@gnu.org (Ludovic Courtès)
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: alex.sassmannshausen@gmail.com, 26264@debbugs.gnu.org
Subject: bug#26264: [PATCH 0/1] Use '@' to separate name, version in package-full-name
Date: Sun, 07 May 2017 17:37:33 +0200 [thread overview]
Message-ID: <87bmr4ptj6.fsf@gnu.org> (raw)
In-Reply-To: <45019b9a-565a-82a9-a0de-249cfe211cfa@tobias.gr> (Tobias Geerinckx-Rice's message of "Sat, 6 May 2017 20:32:14 +0200")
Hello!
Tobias Geerinckx-Rice <me@tobias.gr> skribis:
> From 43892525fc981533445e60a649425791cc315d0a Mon Sep 17 00:00:00 2001
> From: Tobias Geerinckx-Rice <me@tobias.gr>
> Date: Sat, 6 May 2017 14:32:12 +0200
> Subject: [PATCH 4/4] packages: Use "@" as a version separator.
>
> * guix/packages.scm (package-full-name): Use "@" instead of "-" to separate
> PACKAGE-NAME and PACKAGE-VERSION.
> ---
> guix/packages.scm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/guix/packages.scm b/guix/packages.scm
> index 44f2c32fb..802405102 100644
> --- a/guix/packages.scm
> +++ b/guix/packages.scm
> @@ -385,8 +385,8 @@ object."
>
>
> (define (package-full-name package)
> - "Return the full name of PACKAGE--i.e., `NAME-VERSION'."
> - (string-append (package-name package) "-" (package-version package)))
> + "Return the full name of PACKAGE--i.e., `NAME@VERSION'."
> + (string-append (package-name package) "@" (package-version package)))
WDYT of making it:
(define* (package-full-name package #:optional (separator "@"))
…)
?
(I think I suggested it somewhere, but maybe not. :-))
That would make the adjustments to places that need a hyphen slightly
shorter.
Thanks, and good luck with your new $DAYJOB!
Ludo’.
next prev parent reply other threads:[~2017-05-07 15:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170326122555.22366-1-alex@pompo.co>
[not found] ` <6da6e290-feed-e500-e53a-d308e5dc9dde@tobias.gr>
[not found] ` <877f3bx4m3.fsf@gmail.com>
2017-03-28 15:03 ` bug#26264: [PATCH 0/1] Use '@' to separate name, version in package-full-name Ludovic Courtès
2017-03-28 15:19 ` Tobias Geerinckx-Rice
[not found] ` <fe8b8924-3c64-e478-4745-24a692db3a91@tobias.gr>
[not found] ` <87o9wl1j3k.fsf@gnu.org>
2017-03-28 19:49 ` Tobias Geerinckx-Rice
2017-05-06 18:32 ` Tobias Geerinckx-Rice
2017-05-07 15:37 ` Ludovic Courtès [this message]
2017-05-07 21:13 ` Tobias Geerinckx-Rice
2017-05-08 12:39 ` Ludovic Courtès
2017-05-20 9:28 ` Alex Sassmannshausen
2017-05-31 12:11 ` Ludovic Courtès
[not found] ` <20170326122555.22366-2-alex@pompo.co>
2017-03-28 15:06 ` bug#26265: [PATCH 1/1] packages: Add optional `for-ui` param to `package-full-name` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bmr4ptj6.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=26264@debbugs.gnu.org \
--cc=alex.sassmannshausen@gmail.com \
--cc=me@tobias.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.