From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36975)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d8ZQs-0004D5-Sr
	for guix-patches@gnu.org; Wed, 10 May 2017 17:46:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d8ZQp-0007aW-9P
	for guix-patches@gnu.org; Wed, 10 May 2017 17:46:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:34599)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1d8ZQp-0007aK-2n
	for guix-patches@gnu.org; Wed, 10 May 2017 17:46:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d8ZQo-0006ys-UB
	for guix-patches@gnu.org; Wed, 10 May 2017 17:46:02 -0400
Subject: bug#26150: [PATCH 0/15]: Add pplacer and OCaml dependencies.
Resent-Message-ID: <handler.26150.D26150.149445271726764@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <9e1d5f35-c6dc-e55f-dbb2-2649ba5843df@uq.edu.au>
	<87wpczatcg.fsf@gnu.org>
	<5c839114-e4d6-41b2-5b18-fd4d459d56e6@uq.edu.au>
	<87mvcyzrxl.fsf@gnu.org>
	<d4cc770f-f2d0-4a93-cc54-8302eed1d4c7@uq.edu.au>
	<87zifulfjf.fsf@gnu.org>
	<12d5b9fe-5326-d8ba-9d25-f27052f55c94@uq.edu.au>
Date: Wed, 10 May 2017 23:44:57 +0200
In-Reply-To: <12d5b9fe-5326-d8ba-9d25-f27052f55c94@uq.edu.au> (Ben Woodcroft's
	message of "Wed, 10 May 2017 22:28:02 +0200")
Message-ID: <87bmr0qtd2.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ben Woodcroft <b.woodcroft@uq.edu.au>
Cc: 26150@debbugs.gnu.org, 26150-done@debbugs.gnu.org

Hi Ben,

Ben Woodcroft <b.woodcroft@uq.edu.au> skribis:

> On 05/04/17 23:18, Ludovic Court=C3=A8s wrote:
>> Ben Woodcroft <b.woodcroft@uq.edu.au> skribis:
>> [...]
>>
>>> +(define package-with-ocaml4.01
>>> +  (package-with-explicit-ocaml (delay (default-ocaml4.01))
>>> +                               (delay (default-ocaml4.01-findlib))
>>> +                                "ocaml-" "ocaml4.01-"
>>> +                                #:variant-property 'ocaml4.01-variant))
>> I choked for a few hours on this one, my main problem being that I
>> didn=E2=80=99t want us to duplicate the logic from build-system/python.s=
cm.
>> This led to commits f37f2b83fa95c1fe2bf01c4b8072cfc23d4c67ec and
>> 1618006d0bc9bfdc63f4d199fd980f29ecc78ec4.
>>
>> Is the =E2=80=9Cvariant=E2=80=9D property really needed?  In Python it=
=E2=80=99s needed because
>> the 2.x variants sometimes need a different set of dependencies that
>> =E2=80=98package-with-python2=E2=80=99 cannot automatically guess.  Conv=
ersely,
>> =E2=80=98package-with-guile-2.0=E2=80=99 has no need for that.
>>
>> If the variant is not needed, then I recommend using
>> =E2=80=98package-with-input-rewriting=E2=80=99.
>>
>> If the variant is needed, then could you use =E2=80=98package-mapping=E2=
=80=99 as in
>> 1618006d0bc9bfdc63f4d199fd980f29ecc78ec4?
> I ended up pushing this series, ending in
> c033f5d6b5b565c43588d25b7b47d177f0c0933c.
>
> There was one package where a different set of inputs was required
> (ocaml4.01-bisect), so I used 'package-mapping' as suggested. Your
> solution seemed very clean to me, thank you for spending those few
> hours.

That=E2=80=99s good news, thank you!

Ludo=E2=80=99.