From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48650) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8X8b-0005AA-W2 for guix-patches@gnu.org; Wed, 10 May 2017 15:19:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8X8Y-00080n-Ov for guix-patches@gnu.org; Wed, 10 May 2017 15:19:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:34421) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d8X8Y-00080h-L4 for guix-patches@gnu.org; Wed, 10 May 2017 15:19:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d8X8Y-0003RQ-GB for guix-patches@gnu.org; Wed, 10 May 2017 15:19:02 -0400 Subject: bug#26860: [PATCH] Remove hard dependency on guile-json Resent-Message-ID: From: Alex Kost References: <87shkdbye4.fsf@gmail.com> <87a86li5ci.fsf@elephly.net> Date: Wed, 10 May 2017 22:18:07 +0300 In-Reply-To: <87a86li5ci.fsf@elephly.net> (Ricardo Wurmus's message of "Wed, 10 May 2017 08:38:37 +0200") Message-ID: <87bmr0a5cg.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ricardo Wurmus Cc: 26860@debbugs.gnu.org Ricardo Wurmus (2017-05-10 08:38 +0200) wrote: > Alex Kost writes: > >> Hello. Currently, Guix cannot be built without guile-json. The >> attached patch fixes it. >> >>>>From 3a65a2f35b54604327ba69a55381fee0faac18e7 Mon Sep 17 00:00:00 2001 >> From: Alex Kost >> Date: Tue, 9 May 2017 22:44:19 +0300 >> Subject: [PATCH] build: Compile stackage only if 'guile-json' is availab= le. >> >> This is a followup to commit 3089b5d3f5a31b191b68ce3aa9255b646940b642. >> >> * Makefile.am (MODULES): Move "guix/scripts/import/stackage.scm" within >> 'if HAVE_GUILE_JSON'. > > Would it not work to autoload the module? Sorry, I have no idea, I didn't test :-) I can only say that currently the build fails if guile-json is not available, so I came up with a simple fix. > =E2=80=9Cguix/scripts/import/stackage.scm=E2=80=9D itself does not requir= e guile json. Right, it requires (guix import stackage) which requires (guix import json) which requires (json), but not directly. > Something like that is done in commit > fad5f5fb8dffb4a1cbe40ee9d31a346b901305d1 (in the unmerged wip-installer > branch). I don't know, this seems over-complicated to me. Does it really make sense to leave "guix/import/stackage.scm" inside "if HAVE_GUILE_JSON" and "guix/scripts/import/stackage.scm" outside? I would rather keep these stackage import modules in one place and avoid the autoload hack you mentioned. P.S. Sorry if this message is not very constructive, I am not concentrated now as I'm watching "Atl=C3=A9tico =E2=80=93 Real" semi-final. --=20 Alex