From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32825) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dFGPG-0003RG-S3 for guix-patches@gnu.org; Mon, 29 May 2017 04:52:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dFGPC-0001vt-0Z for guix-patches@gnu.org; Mon, 29 May 2017 04:52:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:39829) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dFGPB-0001vj-St for guix-patches@gnu.org; Mon, 29 May 2017 04:52:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dFGPB-0006ly-Kx for guix-patches@gnu.org; Mon, 29 May 2017 04:52:01 -0400 Subject: bug#26941: New font-build-system Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <87bbe3e5.AEAAKL2r-KIAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZGcQo@mailjet.com> <87y3tw4kw3.fsf@gnu.org> <87r2zfx0xt.fsf@gnu.org> <9591bf82.AEUAKjfDcSkAAAAAAAAAAAOzWv8AAAACwQwAAAAAAAW9WABZKceD@mailjet.com> <87fufptaup.fsf@gnu.org> <37b2bd65.AEMAKxmsz0MAAAAAAAAAAAOzWv8AAAACwQwAAAAAAAW9WABZKs1c@mailjet.com> Date: Mon, 29 May 2017 10:51:05 +0200 In-Reply-To: <37b2bd65.AEMAKxmsz0MAAAAAAAAAAAOzWv8AAAACwQwAAAAAAAW9WABZKs1c@mailjet.com> (Arun Isaac's message of "Sun, 28 May 2017 18:45:02 +0530") Message-ID: <87bmqcdp1i.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Arun Isaac Cc: 26941@debbugs.gnu.org Arun Isaac skribis: >>>>> A side issue: I feel that the `install-file' procedure should print o= ut >>>>> what it's doing to stdout (or some log port). Something like: >>>>> >>>>> (format #t "~a -> ~a~%" source destination) >>>>> >>>>> This would save us the trouble of implementing this log printing >>>>> everywhere `install-file' is called. For example, this could be very >>>>> useful in the 'install' phase of the font-build-sytem. WDYT? >>>> >>>> Do we really need to print something in the first place? :-) Some >>>> procedures in (guix build utils) do that, indeed, but I=E2=80=99m not = sure it=E2=80=99s >>>> useful for something as simple as =E2=80=98install-file=E2=80=99. Tho= ughts? >>> >>> Yes, I think it is really important. Without the verbose output, one >>> will have to stare at a blank screen, guessing at what is >>> happening. Long verbose output feels reassuring that something is going >>> on. :-) Also, verbose output for `install-file' might help in debugging >>> correct source/destination paths. >> >> OK. I=E2=80=99m not entirely convinced, because I think that either the= build >> completes and it=E2=80=99s easy to check that the files are where you wa= nted >> them to be, or it fails, and you get an exception. I=E2=80=99m not stro= ngly >> opposed either, so perhaps something to consider in the next >> =E2=80=98core-updates=E2=80=99 cycle. > > Should I send a patch for this? Maybe we should see if there=E2=80=99s support for this. If you could get a couple of =E2=80=9C+1=E2=80=9Ds, that=E2=80=99d be good. :-) >>> From a0bda2fc48c6d2c7809805251154c49e8be76d67 Mon Sep 17 00:00:00 2001 >>> From: Arun Isaac >>> Date: Mon, 15 May 2017 20:08:57 +0530 >>> Subject: [PATCH 1/5] build-system: Add 'font-build-system'. >>> >>> * Makefile.am (MODULES): Add 'guix/build-system/font.scm' and >>> 'guix/build/font-build-system.scm'. >>> * guix/build-system/font.scm: New file. >>> * guix/build/font-build-system.scm: New file. >>> * doc/guix.texi (Build Systems): Add 'font-build-system'. >> >> Alright, OK for this and the following patches. > > I'll push these shortly, and begin work on migrating the other font > packages to the new font-build-system. Awesome! Ludo=E2=80=99.