From: Marius Bakke <mbakke@fastmail.com>
To: "Gábor Boskovits" <boskovits@gmail.com>, 27469@debbugs.gnu.org
Subject: [bug#27469] [PATCH] gnu: Add quagga.
Date: Sun, 25 Jun 2017 15:05:17 +0200 [thread overview]
Message-ID: <87bmpcnroy.fsf@fastmail.com> (raw)
In-Reply-To: <20170624001044.20683-1-boskovits@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2164 bytes --]
Gábor Boskovits <boskovits@gmail.com> writes:
> * gnu/packages/networking.scm (quagga): New variable.
> * gnu/packages/patches/quagga-reproducible-build.patch: New file.
Thanks for this!
[...]
> +(define-public quagga
> + (package
> + (name "quagga")
> + (version "1.2.1")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append "mirror://savannah/quagga/quagga-"
> + version ".tar.gz"))
> + (sha256
> + (base32
> + "1kgvcr9cfgys5asvb5lh5h95silkr624apqm5x68xva19xfvmpda"))
> + (patches
> + (search-patches "quagga-reproducible-build.patch"))))
> + (build-system gnu-build-system)
> + (native-inputs `(("pkg-config",pkg-config)))
> + (inputs `(("readline",readline)
> + ("c-ares",c-ares)
> + ("perl",perl)
> + ("dejagnu",dejagnu)))
Dejagnu is a software test framework and should probably be a
"native-input", e.g. it's a build-time dependency only.
`guix gc -R (./pre-inst-env guix build quagga)` also lists no references
to perl, so it should likely also be a native-input. What do you think?
> + (synopsis "Routing Software Suite")
> + (description "Quagga is a routing software suite, providing implementations
> +of OSPFv2, OSPFv3, RIP v1 and v2, RIPng and BGP-4 for Unix platforms, particularly
> +FreeBSD, Linux, Solaris and NetBSD.")
> + (home-page "http://www.nongnu.org/quagga/")
> + (license license:gpl2)))
The license is GPL2+ as listed in the source comment headers.
> diff --git a/gnu/packages/patches/quagga-reproducible-build.patch b/gnu/packages/patches/quagga-reproducible-build.patch
> new file mode 100644
> index 000000000..80efe4bf6
> --- /dev/null
> +++ b/gnu/packages/patches/quagga-reproducible-build.patch
> @@ -0,0 +1,22 @@
> +Make sure, that vtysh_cmd.c is deterministically generated.
Good catch! LGTM. Could you submit this fix upstream too?
Also, please add this patch to the relevant section in "gnu/local.mk".
See the commit log for examples.
Can you send an updated patch? Thanks in advance!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2017-06-25 13:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-24 0:10 [bug#27469] [PATCH] gnu: Add quagga Gábor Boskovits
2017-06-25 13:05 ` Marius Bakke [this message]
2017-06-26 15:51 ` Gábor Boskovits
2017-06-26 18:44 ` bug#27469: " Marius Bakke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bmpcnroy.fsf@fastmail.com \
--to=mbakke@fastmail.com \
--cc=27469@debbugs.gnu.org \
--cc=boskovits@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.