From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49809) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eEjz2-0004Y3-NV for guix-patches@gnu.org; Tue, 14 Nov 2017 17:47:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eEjyy-0003m6-Qe for guix-patches@gnu.org; Tue, 14 Nov 2017 17:47:08 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:60295) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eEjyy-0003ls-N4 for guix-patches@gnu.org; Tue, 14 Nov 2017 17:47:04 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eEjyw-0007Zv-DM for guix-patches@gnu.org; Tue, 14 Nov 2017 17:47:04 -0500 Subject: [bug#29210] [PATCH] gnu: messaging: Add libsignal-protocol-c and enable OMEMO for dino. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <5a2d4159793c664e2f6277b9ad0345f5@mykolab.com> Date: Tue, 14 Nov 2017 23:46:19 +0100 In-Reply-To: <5a2d4159793c664e2f6277b9ad0345f5@mykolab.com> (Rutger Helling's message of "Wed, 08 Nov 2017 11:38:00 +0100") Message-ID: <87bmk4lbr8.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Rutger Helling Cc: 29210@debbugs.gnu.org Hi Rutger, Rutger Helling skribis: > From 4212f0c4ffe43464ed7bd2e9f1a8f10e308ec792 Mon Sep 17 00:00:00 2001 > From: Rutger Helling > Date: Wed, 8 Nov 2017 11:16:29 +0100 > Subject: [PATCH] gnu: messaging: Add libsignal-protocol-c. > > * gnu/packages/messaging.scm (libsignal-protocol-c): New variable. [...] > + (arguments > + `(#:tests? #f > + ; Required for proper linking. > + #:configure-flags '("-DBUILD_SHARED_LIBS=3Don"))) > + ; FIXME: With the below additional flags the tests pass, however th= is > + ; causes problems with timestamps, therefore the tests are disabled= for > + ; now: > + ; -DCMAKE_BUILD_TYPE=3DDebug > + ; -DBUILD_TESTING=3D1 What are the timestamp issues you=E2=80=99re referring to above? It would = be nice if we could have our cake and eat it too. :-) Besides, the default in =E2=80=98cmake-build-system=E2=80=99 is =E2=80=9C-DCMAKE_BUILD_TYPE=3DRelWithDebugInfo=E2=80=9D (i.e., =E2=80=9C-O2= -g=E2=80=9D), and I think we should keep it this way here. Nipick: please use two semicolons for block comments like this (one semicolon is for margin comments). > + (home-page "https://github.com/WhisperSystems/libsignal-protocol-c") > + (synopsis "Ratcheting forward secrecy protocol") > + (description "libsignal-protocol-c is a ratcheting forward secrecy pro= tocol > +that works in synchronous and asynchronous messaging environments.") Nitpicking here as well: it=E2=80=99s an /implementation/ of the protocol. Could you also expound the description a little bit? > + (license license:gpl3))) Since source file headers don=E2=80=99t say anything particular, it=E2=80= =99s =E2=80=98gpl3+=E2=80=99 (=E2=80=9Cor any later version=E2=80=9D.) Could you send an updated patch? > From db99f5874d24e0aa3e74005bf7200f459451aeb7 Mon Sep 17 00:00:00 2001 > From: Rutger Helling > Date: Wed, 8 Nov 2017 11:18:38 +0100 > Subject: [PATCH] gnu: messaging: Enable OMEMO for dino. > > * gnu/packages/messaging.scm (dino) Update to commit f6ac5bbd26638412a228= 9fd1d28ef12de1d7e8b5. [inputs]: Add libsignal-protocol-c, libgcrypt. [argum= ents]: Change #configure-flags to "-DSHARED_SIGNAL_PROTOCOL=3Dyes". OK! Thank you, Ludo=E2=80=99.