From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55924) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ePqnT-0002no-6g for guix-patches@gnu.org; Fri, 15 Dec 2017 09:17:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ePqnO-0003ed-EE for guix-patches@gnu.org; Fri, 15 Dec 2017 09:17:07 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:54401) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ePqnO-0003eC-AB for guix-patches@gnu.org; Fri, 15 Dec 2017 09:17:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ePqnO-0005Er-1a for guix-patches@gnu.org; Fri, 15 Dec 2017 09:17:02 -0500 Subject: [bug#29719] [PATCH] gnu: virtualization: Add lookingglass. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: Date: Fri, 15 Dec 2017 15:16:51 +0100 In-Reply-To: (Rutger Helling's message of "Fri, 15 Dec 2017 12:02:31 +0100") Message-ID: <87bmj0hy98.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Rutger Helling Cc: 29719@debbugs.gnu.org Hello! Rutger Helling skribis: > From ccea9a6c9dd71aea5ef5c07802f7e376a7f86a96 Mon Sep 17 00:00:00 2001 > From: Rutger Helling > Date: Fri, 15 Dec 2017 11:58:10 +0100 > Subject: [PATCH] gnu: virtualization: Add lookingglass. > > * gnu/packages/virtualization.scm (lookingglass): New variable. [...] > +(define-public lookingglass > + (package > + (name "lookingglass") Please run: ./etc/indent-code.el gnu/packages/virtualization.scm lookingglass > + (version "a5") > + (source > + (origin > + (method url-fetch) > + (uri (string-append "https://github.com/gnif/LookingGlass/archive/" > + version ".tar.gz")) > + (file-name (string-append name "-" version)) > + (sha256 > + (base32 > + "0lrb821914fp27xaq0spwhbblssz55phiygvdlvcrkifa138v8pf")))) > + (build-system gnu-build-system) > + (inputs `(("fontconfig" ,fontconfig) > + ("glu" ,glu) > + ("mesa" ,mesa) > + ("openssl" ,openssl) > + ("sdl2" ,sdl2) > + ("sdl2-ttf" ,sdl2-ttf) > + ("spice-protocol" ,spice-protocol))) > + (native-inputs `(("pkg-config", pkg-config))) > + (arguments > + `(#:tests? #f ;; No tests are available. > + #:phases (modify-phases %standard-phases > + (replace 'configure > + (lambda* (#:key outputs #:allow-other-keys) > + (chdir "client"))) Return #t. > + (replace 'install > + (lambda* (#:key outputs #:allow-other-keys) > + (mkdir-p (string-append %output "/bin")) > + (copy-file "bin/looking-glass-client" (string-appe= nd > + %output "/bin/looking-glass-client"))))= ))) Same here. Use the =E2=80=98outputs=E2=80=99 argument instead of the =E2=80=98%output= =E2=80=99 global variable. Also, you can replace the mkdir-p/copy-file pair with just: (install-file "bin/looking-glass-client" (string-append (assoc-ref outputs "out") "/bin")) > + (home-page "https://looking-glass.hostfission.com") > + (synopsis "Low-latency KVMFR implementation for QEMU guests with VGA = PCI > +passthrough") > + (description "LookingGlass is an extremely low latency KVMFR (KVM Fra= meRelay) > +implementation for QEMU guests with VGA PCI Passthrough.") Could you shorten the synopsis and expound the description a little bit? :-) I find it hard to understand what this is about looking at this. > + (license gpl2))) AFAICS source file headers explicitly say =E2=80=9Cor any later version=E2= =80=9D, so this should be =E2=80=98gpl2+=E2=80=99. The rest LGTM. Could you send an updated patch? Thank you! Ludo=E2=80=99.