From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48275) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebjME-0006c3-I8 for guix-patches@gnu.org; Wed, 17 Jan 2018 03:46:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebjMB-0002O5-Cf for guix-patches@gnu.org; Wed, 17 Jan 2018 03:46:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:51478) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ebjMB-0002Ng-95 for guix-patches@gnu.org; Wed, 17 Jan 2018 03:46:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ebjMA-0000kz-RQ for guix-patches@gnu.org; Wed, 17 Jan 2018 03:46:02 -0500 Subject: bug#29741: [PATCH 2/2] gnu: services: web: Add service for httpd. Resent-To: guix-patches@gnu.org Resent-Message-ID: References: <87zi6gtkhx.fsf@gnu.org> <20171224180157.21873-1-mail@cbaines.net> <20171224180157.21873-2-mail@cbaines.net> <87d12gp193.fsf@gnu.org> From: Christopher Baines In-reply-to: <87d12gp193.fsf@gnu.org> Date: Wed, 17 Jan 2018 08:45:24 +0000 Message-ID: <87bmhsub4r.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 29741-done@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hi Chris! > > Sorry for the delay. > > Christopher Baines skribis: > >> * gnu/services/web.scm (, >> , >> ): New record types. >> (%default-httpd-modules, %httpd-accounts, >> httpd-service-type): New variables. >> (httpd-shepherd-services, httpd-activation, >> httpd-process-extensions): New procedures. >> * gnu/tests/web.scm (run-httpd-test): New procedure. >> (%httpd-os, %tests-httpd): New variables. >> * doc/guix.texi (Web Services): Document the Apache HTTP Server. > > [...] > >> +The @code{(gnu services web)} module provides the Apache HTTP Server, >> +the nginx web server, and also a fastcgi wrapper daemon. >> + >> +@subsubheading Apache HTTP Server >> + >> +@deffn {Scheme Variable} httpd-service-type >> +Service type for the @uref{https://httpd.apache.org/,Apache HTTP} >> +server. The value for this service type is a @code{https-configuration} > ^ > Maybe add =E2=80=9C(@dfn{httpd})=E2=80=9D. > > Apart from this super-nitpicky comment, this LGTM! :-) Great, I've made that change and pushed. Thanks for reviewing Ludo :) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlpfDSRfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9Xfh2Q/9G33fS6m/+/HtakpW0yRw0kc4ocHbpG7lzzReQthQxdk+Y4wjJMDs7PES KDKlQN19wcN8ExtA127g33QMMZd45JN1B9MaCJEwlSoXrMZuxghzUP5lHbMaIGaS RwpVCNa78ctOBIvk1E15cqiy7bMjw1ATwH3agScWOoZTVyiRzLk96ZwUsDoqcs/3 ACsoiDFG2q38xGFdnfoeS8wn1S6p712Tpa9vqa7krsZzuixvKhNqDczvRQdwg13E SbLQYvkVlluyWI12Q4oYDcFfXi75QbYHf1MQ7hjHasU45Cq3yq+hn+GxwILHhvGq bKcdpESb0wqbmcD1eA4WC4TH1TSx4oEAmVfwE4gCCKOUQ7dKozIAb5GCtBrZfNCK bzMEpbS9YLvA+ljtcgCDUZp29X6ajLkHX0ErilE6/ky2y3qboOukZMWjPMokcqy3 tQk0DgXKrmUy+hUgPIWka0rFHO/8Iz1cCRGHGMYrE8rjgo3l06b4IMD9wpLFNUvK lsACHdBpBWPTyYzvDls16ckgtL8/38lL3tjVuAYvv0HToKgfmgC3Dztn68InNGgv bTQmeZm3s2xUFXuvsa+3cl6vBMSa+711IGmUHJVZqEmnE1GBgIWEcOSgA74K3xvX CjzMGvZUGBg71QVH6+4FWODUd669maXSRu65U63B6gF35MP4xaQ= =ICEw -----END PGP SIGNATURE----- --=-=-=--