From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46974) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ejQ0A-0000iL-41 for guix-patches@gnu.org; Wed, 07 Feb 2018 08:43:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ejQ07-0000BR-2H for guix-patches@gnu.org; Wed, 07 Feb 2018 08:43:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:53071) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ejQ06-0000BN-UF for guix-patches@gnu.org; Wed, 07 Feb 2018 08:43:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ejQ06-00087g-NS for guix-patches@gnu.org; Wed, 07 Feb 2018 08:43:02 -0500 Subject: [bug#30119] [PATCHv2] Add emacs-realgud and varia Resent-Message-ID: From: Maxim Cournoyer References: <87d12bbwfa.fsf@gmail.com> <87bmhi8pac.fsf@gmail.com> <87lggfvyz2.fsf@gnu.org> <87bmh4umpp.fsf@gmail.com> <87po5ja0ow.fsf@gnu.org> Date: Wed, 07 Feb 2018 08:42:50 -0500 In-Reply-To: <87po5ja0ow.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Mon, 05 Feb 2018 16:57:51 +0100") Message-ID: <87bmh07w6d.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 30119-done@debbugs.gnu.org Hi Ludovic, ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Hi Maxim, > > Maxim Cournoyer skribis: > >> From 4e9e0f1358b65c180218412f667a2dbb4e1b2b19 Mon Sep 17 00:00:00 2001 >> From: Maxim Cournoyer >> Date: Sun, 14 Jan 2018 22:38:20 -0500 >> Subject: [PATCH 3/7] emacs-build-system: Work around issue 30116. >> >> This is a temporary workaround issue 30116, where substitute* crashes on >> files containing NUL characters. >> >> * guix/build/emacs-build-system.scm (patch-el-files): Filter out elisp f= iles >> that contain NUL characters. > > I applied the whole series but there was an issue in this one, so I took > the liberty to change it as follows: > > 1. clarify comments; > > 2. make sure =E2=80=98el-files=E2=80=99 is a list of absolute file name= s; previously > it would fail beacuse =E2=80=98el-files=E2=80=99 was used with a dif= ferent cwd. Thank you! I wonder why I had not encountered the issue; we used to use that very (find-files . "\\.el$") expression before that change, so in all cases it was already broken if it truly was :). Thank you! Maxim